fix: fix error on install due to usage of use in factory closure
#283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes an error on install with recent prestashop releases caused by the `psVersionFactory` Fixes #281, Closes INT-695
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
============================================
- Coverage 51.96% 48.15% -3.81%
+ Complexity 712 561 -151
============================================
Files 152 148 -4
Lines 4191 3721 -470
Branches 55 55
============================================
- Hits 2178 1792 -386
+ Misses 1958 1874 -84
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
GravendeelJochem
approved these changes
Oct 21, 2024
FlorianSDV
approved these changes
Oct 22, 2024
|
✅ Build successful! You can find a link to the downloadable artifact below. |
myparcel-bot bot
added a commit
that referenced
this pull request
Oct 30, 2024
## [4.1.0](v4.0.0...v4.1.0) (2024-10-30) ### 🐛 Bug Fixes * fix error on install due to usage of `use` in factory closure ([#283](#283)) ([1b4fdca](1b4fdca)), closes [#281](#281) ### ⚡ Performance Improvements * **admin:** only save product settings once per request ([#279](#279)) ([e60bce1](e60bce1)) ### ✨ New Features * **deps:** upgrade @myparcel-pdk/* ([0cd4941](0cd4941)) * **deps:** upgrade myparcelnl/pdk to v2.45.0 ([6ff668d](6ff668d))
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes an error on install with recent prestashop releases caused by the
psVersionFactoryFixes #281, Closes INT-695