Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] internal walls of clumps of echoes tend to flicker in and out of existence #22

Closed
1 task done
mzdun opened this issue Oct 7, 2024 · 0 comments · Fixed by #26
Closed
1 task done

[BUG] internal walls of clumps of echoes tend to flicker in and out of existence #22

mzdun opened this issue Oct 7, 2024 · 0 comments · Fixed by #26
Labels
bug Something isn't working needs triage

Comments

@mzdun
Copy link
Owner

mzdun commented Oct 7, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

When echoes are clumped together, their internal walls should not be visible. Sometimes they are, however.

Steps To Reproduce

  1. Start a scan
  2. Look for a close larger clump of echoes
  3. Wiggle a bit
  4. See internal walls appear and disappear

Expected Behavior

Clumps are always showing their outer walls only

Game Version

1.21

Launcher

Fabric

Version

v0.4.0

Operating Systems

  • Unspecified

Anything else?

image
image
@mzdun mzdun added bug Something isn't working needs triage labels Oct 7, 2024
@mzdun mzdun mentioned this issue Oct 7, 2024
Closed
3 tasks
mzdun added a commit that referenced this issue Oct 9, 2024
@mzdun
feat: clumping echoes in nuggets
114de78 
Now we have:

- limited number of `Echo`s -- they should be ideally only one per Id,
  for now it is one per one scan; in the future, the label might be also
  stored there
- `BlockEcho` is an `Echo` with a position and ping time.
- _(new)_ `EchoState` is a `BlockEcho`, with information, which sides
  and edges are visible
- _(new)_ `EchoNugget` is a clump of all touching echoes of the same id
- `BlockEchoes` is a container for all known `BlockEcho`es and now a
  container of all known `EchoNugget`s

fixes: #22
closes: #23
@mzdun mzdun mentioned this issue Oct 9, 2024
Merged
mzdun added a commit that referenced this issue Oct 9, 2024
@mzdun
feat: clumping echoes in nuggets
1dfd23d 
Now we have:

- limited number of `Echo`s -- they should be ideally only one per Id,
  for now it is one per one scan; in the future, the label might be also
  stored there
- `BlockEcho` is an `Echo` with a position and ping time.
- _(new)_ `EchoState` is a `BlockEcho`, with information, which sides
  and edges are visible
- _(new)_ `EchoNugget` is a clump of all touching echoes of the same id
- `BlockEchoes` is a container for all known `BlockEcho`es and now a
  container of all known `EchoNugget`s

fixes: #22
closes: #23
@mzdun mzdun closed this as completed in #26 Oct 9, 2024
mzdun added a commit that referenced this issue Oct 9, 2024
@mzdun
chore: release 0.5.0
cb11924 
New Features:

 - locate the thing I'm looking at (e6d0658)
 - clumping echoes in nuggets (1dfd23d), closes #23, fixes #22
 - adding new level of indirection (1a8b096)

Chores:

 - use :fabric:1.21 as base for other versions (666e979)

Code Refactoring:

 - merging `BlockEcho` and `EchoState` (5b6f2fd)
 - s/GraphicContext/ShimmerConsumer/ (fa0b40a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clumps of blocks mzdun/resource-scanner-mc
1 participant
@mzdun