Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

CLI & Rust API crate organization #153

Closed
b5 opened this issue Oct 10, 2022 · 2 comments
Closed

CLI & Rust API crate organization #153

b5 opened this issue Oct 10, 2022 · 2 comments
Assignees

Comments

@b5
Copy link
Member

b5 commented Oct 10, 2022

@dignifiedquire @faassen & I have come to consensus on how to organize crates at the top level of the Iroh project:

  • iroh will be the CLI crate.
  • iroh-api will contain the rust API to iroh.
  • iroh will import iroh-api, clap, and that's about it. All types needed to interact with iroh must be exported by iroh-api

This should clear up confusion that's arisen on a few issues:

Let's mark this as closed once the rough crate organization matches this decision.

@b5 b5 mentioned this issue Feb 17, 2023
@faassen
Copy link
Contributor

faassen commented Oct 10, 2022

I'll note that this PR already goes in the direction of making iroh-ctl only depend on the API:

n0-computer/iroh#316

While I'm writing I realize I can also depend on Api for cid and a few other things, will update the PR.

The PR does the rename of iroh to iroh-api too, though not yet iroh-ctl to iroh, as that creates an absolutely unreadable PR.

@faassen
Copy link
Contributor

faassen commented Oct 11, 2022

With n0-computer/iroh#321 this is now done

@faassen faassen closed this as completed Oct 11, 2022
@dignifiedquire dignifiedquire transferred this issue from n0-computer/iroh Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants