Iroh ctl into iroh one #296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faassen
force-pushed
the
iroh-ctl-into-iroh-one
branch
from
fa83573 to
fde65ee
Compare
Not sure why it still worked with `iroh-ctl`!
faassen
force-pushed
the
iroh-ctl-into-iroh-one
branch
from
fd295b0 to
bbb4f06
Compare
|
There was a change in direction and we're keeping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a mostly mechanical move of what was in
iroh-ctlintoiroh-one, and removingiroh-ctl.I've introduced a
startcommand iniroh-oneand moved everything related to the existingiroh-oneCTL under there. I've then added everything under the existing CLI.iroh startdoesn't, as far as I know, present enough RPC surface at present to allow future invocations ofirohto connect to it, so that's not part of this PR.Consolidation of stuff appears possible - in particular
config_ctl.rsandconfig_one.rsappear to have overlaps. I haven't dealt with this in the interest of first completing the move of the code itself.