Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose downloader config for blobs builder #74

Open
rklaehn opened this issue Mar 13, 2025 · 0 comments
Open

Expose downloader config for blobs builder #74

rklaehn opened this issue Mar 13, 2025 · 0 comments
Assignees
@rklaehn
Labels
enhancement New feature or request
Milestone
v0.34.0

Comments

@rklaehn
Copy link
Collaborator

rklaehn commented Mar 13, 2025

The ability to configure the downloader when building a Blobs protocol handler got lost at some point, apparently here: #47

We need to make this possible again.
@rklaehn rklaehn added the enhancement New feature or request label Mar 13, 2025
@rklaehn rklaehn added this to the v0.34.0 milestone Mar 13, 2025
@rklaehn rklaehn self-assigned this Mar 13, 2025
@rklaehn rklaehn added this to iroh Mar 13, 2025
@arilotter arilotter mentioned this issue Mar 13, 2025
Merged
4 tasks
rklaehn pushed a commit that referenced this issue Mar 14, 2025
@arilotter
feat: modify Downloader config through Blobs builder (#75)
6e9f06b 
## Description
A fix for #74 , allowing
users of the Blobs protocol to once again provide configuration for the
internally-used Downloader struct - both concurrency and retry options.
This PR exposes them through the Blobs Builder struct.

## Notes & open questions
I haven't added tests, but this seems to work fine. I probably need
tests for these methods to be a good OSS citizen ;)

## Change checklist

- [x] Self-review.
- [x] Documentation updates following the [style
guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text),
if relevant.
- [ ] Tests if relevant.
- [x] All breaking changes documented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rklaehn rklaehn

Labels
enhancement New feature or request
Projects
iroh
Status: No status
Milestone
v0.34.0
Development

No branches or pull requests
1 participant
@rklaehn