feat!: simplify LocalPool handling #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/47/docs/iroh_blobs/ Last updated: 2025-01-17T09:57:28Z |
It has been a footgun for a few users, including myself, to make sure to keep around the `LocalPool`. This changes the behaviour to construct a `LocalPool` and keep it around by default. If necessary, in the builder one can provide a custom handle, if there is the need for a custom pool.
dignifiedquire
force-pushed
the
feat-simplify-local-pool
branch
from
6ed5ca7 to
5e56fb0
Compare
matheus23
reviewed
Jan 17, 2025
Comment on lines
+171
to
+172
| .map(Rt::Handle) | ||
| .unwrap_or_else(|| Rt::Owned(LocalPool::default())); |
There was a problem hiding this comment.
Suggested change
| .map(Rt::Handle) | |
| .unwrap_or_else(|| Rt::Owned(LocalPool::default())); | |
| .map_or_else(|| Rt::Owned(LocalPool::default()), Rt::Handle); |
But like... could also be a match statement.
matheus23
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It has been a footgun for a few users, including myself, to make sure to keep around the
LocalPool. This changes the behaviour to construct aLocalPooland keep it around by default. If necessary, in the builder one can provide a custom handle, if there is the need for a custom pool.Breaking Changes
net_protocol::Blobs::new, use the builder insteadLocalPoolHandleargument fromnet_protocol::Builder::buildNotes & open questions
Change checklist