Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modify Downloader config through Blobs builder #75

Merged

Conversation

arilotter
Copy link
Contributor

Description

A fix for #74 , allowing users of the Blobs protocol to once again provide configuration for the internally-used Downloader struct - both concurrency and retry options.
This PR exposes them through the Blobs Builder struct.

Notes & open questions

I haven't added tests, but this seems to work fine. I probably need tests for these methods to be a good OSS citizen ;)

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@rklaehn rklaehn self-requested a review March 14, 2025 08:42
Copy link
Collaborator

@rklaehn rklaehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I will merge this and then deal with testability in a subsequent PR. It could be that things will get shuffled around a bit to allow testability, but the functionality to configure the downloader will be in the next release.

@rklaehn rklaehn merged commit 6e9f06b into n0-computer:main Mar 14, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants