-
Notifications
You must be signed in to change notification settings - Fork 4
refactor: move path logic for received path response to path #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/quinn/pr/259/docs/iroh_quinn/ Last updated: 2025-12-16T14:56:03Z |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
==========================================
- Coverage 76.52% 76.50% -0.02%
==========================================
Files 83 83
Lines 23158 23167 +9
==========================================
+ Hits 17721 17724 +3
- Misses 5437 5443 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dignifiedquire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice
Description
Moves logic about receiving path response to the path state. This helps
simplify the connection logic and have a better separation of concerns
technically this also fixes a bug where we send multiple path open events
Breaking Changes
n/a
Notes & open questions
n/a