Skip to content

Conversation

@divagant-martian
Copy link
Collaborator

@divagant-martian divagant-martian commented Dec 15, 2025

Description

Moves logic about receiving path response to the path state. This helps
simplify the connection logic and have a better separation of concerns

technically this also fixes a bug where we send multiple path open events

Breaking Changes

n/a

Notes & open questions

n/a

@github-actions
Copy link

github-actions bot commented Dec 15, 2025

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/quinn/pr/259/docs/iroh_quinn/

Last updated: 2025-12-16T14:56:03Z

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 73.80952% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.50%. Comparing base (9cac306) to head (01536ac).

Files with missing lines Patch % Lines
quinn-proto/src/connection/paths.rs 71.42% 8 Missing ⚠️
quinn-proto/src/connection/mod.rs 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
- Coverage   76.52%   76.50%   -0.02%     
==========================================
  Files          83       83              
  Lines       23158    23167       +9     
==========================================
+ Hits        17721    17724       +3     
- Misses       5437     5443       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@divagant-martian divagant-martian changed the base branch from main-iroh to main December 16, 2025 14:18
Copy link
Collaborator

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

@divagant-martian divagant-martian added this pull request to the merge queue Dec 16, 2025
Merged via the queue into main with commit 706cb2d Dec 16, 2025
27 of 28 checks passed
@divagant-martian divagant-martian deleted the refactor-handle-path-response branch December 16, 2025 15:12
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in iroh Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants