fix(beeminder Node): fix request id not being sent when creating a ne…

…w datapoint
n8n-io · Sep 2, 2022 · 73c5210 · 73c5210
1 parent 071ab40
commit 73c5210
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 8 deletions.
diff --git a/packages/nodes-base/credentials/BeeminderApi.credentials.ts b/packages/nodes-base/credentials/BeeminderApi.credentials.ts
@@ -1,4 +1,9 @@
-import { ICredentialType, INodeProperties } from 'n8n-workflow';
+import {
+	IAuthenticateGeneric,
+	ICredentialTestRequest,
+	ICredentialType,
+	INodeProperties,
+} from 'n8n-workflow';
 
 export class BeeminderApi implements ICredentialType {
 	name = 'beeminderApi';
@@ -18,4 +23,20 @@ export class BeeminderApi implements ICredentialType {
 			default: '',
 		},
 	];
+
+	authenticate: IAuthenticateGeneric = {
+		type: 'generic',
+		properties: {
+			body: {
+				auth_token: '={{$credentials.authToken}}',
+			},
+		},
+	};
+
+	test: ICredentialTestRequest = {
+		request: {
+			baseURL: 'https://www.beeminder.com/api/v1',
+			url: `=/users/{{$credentials.user}}.json`,
+		},
+	};
 }
diff --git a/packages/nodes-base/nodes/Beeminder/Beeminder.node.ts b/packages/nodes-base/nodes/Beeminder/Beeminder.node.ts
@@ -8,7 +8,6 @@ import {
 	INodePropertyOptions,
 	INodeType,
 	INodeTypeDescription,
-	NodeOperationError,
 } from 'n8n-workflow';
 
 import {
@@ -197,7 +196,7 @@ export class Beeminder implements INodeType {
 					},
 					{
 						displayName: 'Request ID',
-						name: 'requestId',
+						name: 'requestid',
 						type: 'string',
 						default: '',
 						placeholder: '',

diff --git a/packages/nodes-base/nodes/Beeminder/GenericFunctions.ts b/packages/nodes-base/nodes/Beeminder/GenericFunctions.ts
@@ -15,10 +15,6 @@ export async function beeminderApiRequest(
 	query: IDataObject = {},
 	// tslint:disable-next-line:no-any
 ): Promise<any> {
-	const credentials = (await this.getCredentials('beeminderApi')) as IDataObject;
-
-	Object.assign(body, { auth_token: credentials.authToken });
-
 	const options: OptionsWithUri = {
 		method,
 		body,
@@ -36,7 +32,7 @@ export async function beeminderApiRequest(
 	}
 
 	try {
-		return await this.helpers.request!(options);
+		return await this.helpers.requestWithAuthentication.call(this, 'beeminderApi', options);
 	} catch (error) {
 		throw new NodeApiError(this.getNode(), error);
 	}