-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(editor): Showing string numbers and null properly in JSON view #4513
Merged
cstuncsik
merged 8 commits into
master
from
n8n-5282-ndv-json-view-represents-strings-as
Nov 7, 2022
Merged
fix(editor): Showing string numbers and null properly in JSON view #4513
cstuncsik
merged 8 commits into
master
from
n8n-5282-ndv-json-view-represents-strings-as
Nov 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
Authored by the n8n team
ui
Enhancement in /editor-ui or /design-system
labels
Nov 2, 2022
…iew-represents-strings-as # Conflicts: # package-lock.json
cstuncsik
changed the title
fix(editor): showing string numbers and null properly in JSON view
fix(editor): Showing string numbers and null properly in JSON view
Nov 4, 2022
mutdmour
previously approved these changes
Nov 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. minor comment on the test
…iew-represents-strings-as # Conflicts: # package-lock.json
mutdmour
approved these changes
Nov 7, 2022
MiloradFilipovic
added a commit
that referenced
this pull request
Nov 7, 2022
* master: fix(editor): Showing string numbers and null properly in JSON view (#4513) fix(editor): Switch `CodeNodeEditor` linter parser to `esprima-next` (#4524) fix(API): Do not use names for typeorm connections (#4532) refactor(editor): Encapsulate canvas actions (#4416) fix: Database config should resolve entities and migrations folder relative to it's path (no-changelog) (#4527) feat(API): Set up error tracking using Sentry (#4394) fix(editor): Curb arg linting for `$input.first()` and `$input.last()` (#4526) fix(HTTP Request Node): use the data in "Put Output in Field" field (#4487) refactor: consolidate database configs (#4522) # Conflicts: # packages/editor-ui/src/views/NodeView.vue
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.