Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: consolidate database configs #4522

Merged
merged 3 commits into from
Nov 4, 2022
Merged

refactor: consolidate database configs #4522

merged 3 commits into from
Nov 4, 2022

Conversation

netroy
Copy link
Member

@netroy netroy commented Nov 4, 2022

and allow overriding the sqlite file name.

DB tests are running here.

@netroy netroy requested review from alexgrozav and ivov November 4, 2022 11:15
@linear
Copy link

linear bot commented Nov 4, 2022

N8N-5384

N8N-5165

@netroy netroy requested a review from krynble November 4, 2022 11:17
@alexgrozav
Copy link
Member

alexgrozav commented Nov 4, 2022

Looks good to me! @ivov and @krynble, please take a look as well.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Nov 4, 2022
@netroy netroy merged commit eb3fffd into master Nov 4, 2022
@netroy netroy deleted the N8N-5384-N8N-5165 branch November 4, 2022 13:23
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Nov 4, 2022
MiloradFilipovic added a commit that referenced this pull request Nov 7, 2022
* master:
  fix(editor): Showing string numbers and null properly in JSON view (#4513)
  fix(editor): Switch `CodeNodeEditor` linter parser to `esprima-next` (#4524)
  fix(API): Do not use names for typeorm connections (#4532)
  refactor(editor): Encapsulate canvas actions (#4416)
  fix: Database config should resolve entities and migrations folder relative to it's path (no-changelog) (#4527)
  feat(API): Set up error tracking using Sentry (#4394)
  fix(editor): Curb arg linting for `$input.first()` and `$input.last()` (#4526)
  fix(HTTP Request Node): use the data in "Put Output in Field" field (#4487)
  refactor: consolidate database configs (#4522)

# Conflicts:
#	packages/editor-ui/src/views/NodeView.vue
@janober
Copy link
Member

janober commented Nov 10, 2022

Got released with n8n@0.202.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants