fix(core): Fix the issue with test webhooks getting removed incorrectly (no-changelog) #5466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly (no-changelog) This broke because of the change [here](https://github.com/n8n-io/n8n/pull/5443/files#diff-b386248ff00977749c873ed85821c241b773e9740d7e7adf94e05b73b350ed74L152). `finally` block is called even if there is a `return` in the `try` block, and this is causing the test webhook to be removed, even when it shouldn't be removed.
n8n-assistant
bot
added
core
Joffcom
approved these changes
Feb 13, 2023
n8n-assistant
bot
added
the
Upcoming Release
|
Got released with |
MiloradFilipovic
added a commit
that referenced
this pull request
Feb 15, 2023
* master: ci(core): Add unit tests for "me" controller (no-changelog) (#5479) fix(core): Use stricter typing on queries in cli commands (no-changelog) (#5476) fix(editor): Fix Vite dev mode (no-changelog) (#5475) feat(editor): Add correct credential owner contact details for readonly credentials (#5208) feat: Add workflow and credential sharing access e2e tests (#5463) ci: Update the "Check Documentation URLs" workflow (no-changelog) (#5473) feat(editor): Upgrade to Storybook v7 (no-changelog) (#5454) docs: Update release notes link (#5472) test(editor): Add e2e tests for executions preview (#5458) 📚 Update CHANGELOG.md and main package.json to 0.215.2 🔖 Release n8n@0.215.2 fix(core): Fix the issue with test webhooks getting removed incorrectly (no-changelog) (#5466) # Conflicts: # pnpm-lock.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke because of the change here.
finallyblock is called even if there is areturnin thetryblock, and this is causing the test webhook to be removed, even when it shouldn't be removed.Fixes #5465