Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix Vite dev mode (no-changelog) #5475

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Feb 14, 2023

because of the updated dev tooling in #5454, vite dev mode is crashing because of the util package looking for process.env.

@netroy netroy requested a review from alexgrozav February 14, 2023 14:33
because of the updated dev tooling in n8n-io#5454, vite dev mode is crashing because of the `util` package looking for `process.env`.
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Feb 14, 2023
@netroy netroy merged commit 522ddfc into n8n-io:master Feb 14, 2023
@netroy netroy deleted the fix-vite-dev branch February 14, 2023 15:10
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Feb 14, 2023
MiloradFilipovic added a commit that referenced this pull request Feb 15, 2023
* master:
  ci(core): Add unit tests for "me" controller (no-changelog) (#5479)
  fix(core): Use stricter typing on queries in cli commands (no-changelog) (#5476)
  fix(editor): Fix Vite dev mode (no-changelog) (#5475)
  feat(editor): Add correct credential owner contact details for readonly credentials (#5208)
  feat: Add workflow and credential sharing access e2e tests (#5463)
  ci: Update the "Check Documentation URLs" workflow (no-changelog) (#5473)
  feat(editor): Upgrade to Storybook v7 (no-changelog) (#5454)
  docs: Update release notes link (#5472)
  test(editor): Add e2e tests for executions preview (#5458)
  📚 Update CHANGELOG.md and main package.json to 0.215.2
  🔖 Release n8n@0.215.2
  fix(core): Fix the issue with test webhooks getting removed incorrectly (no-changelog) (#5466)

# Conflicts:
#	pnpm-lock.yaml
MiloradFilipovic added a commit that referenced this pull request Feb 15, 2023
* master:
  fix(core): Fix data transformation function that are reported not to work properly (#5338)
  ci(core): Add unit tests for "me" controller (no-changelog) (#5479)
  fix(core): Use stricter typing on queries in cli commands (no-changelog) (#5476)
  fix(editor): Fix Vite dev mode (no-changelog) (#5475)
  feat(editor): Add correct credential owner contact details for readonly credentials (#5208)
  feat: Add workflow and credential sharing access e2e tests (#5463)
  ci: Update the "Check Documentation URLs" workflow (no-changelog) (#5473)
  feat(editor): Upgrade to Storybook v7 (no-changelog) (#5454)
@janober
Copy link
Member

janober commented Feb 16, 2023

Got released with n8n@0.216.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team skip-e2e ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants