fix(core): Account for activation error caused by follower main instance
#7735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
3 flaky tests on run #2926 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Credentials > should create a new credential using Add Credential button |
Screenshots
Video
|
|
6-code-node.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Code node > Code editor > should execute the placeholder successfully in both modes |
Screenshots
Video
|
|
20-workflow-executions.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Current Workflow Executions > should render executions tab correctly |
Screenshots
Video
|
|
Review all test suite changes for PR #7735 ↗︎
|
✅ All Cypress E2E specs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accounts for the edge case where the user on a FE connected to a follower
maininstance leads to an activation failure. The follower performs the DB update, skips activation inActiveWorkflows, instructs leader to perform activation inActiveWorkflows, leader fails to activate and reverts the DB update and communicates activation error to follower, which broadcasts the event to all connected FEs, which update their stores and display the activation error.To reproduce, create a workflow with a trigger with an invalid credential and attempt to activate on both leader and follower to trigger the activation error - behavior should be identical on both.