fix(core): Account for activation error caused by follower main instance

packages/cli/src/Interfaces.ts

@@ -471,7 +471,13 @@ export type IPushData =
 	| PushDataActiveWorkflowUsersChanged
 	| PushDataWorkerStatusMessage
 	| PushDataWorkflowActivated
-	| PushDataWorkflowDeactivated;
+	| PushDataWorkflowDeactivated
+	| PushDataWorkflowFailedToActivate;
+
+type PushDataWorkflowFailedToActivate = {
+	data: IWorkflowFailedToActivate;
+	type: 'workflowFailedToActivate';
+};
 
 type PushDataWorkflowActivated = {
 	data: IActiveWorkflowChanged;
@@ -561,6 +567,11 @@ interface IActiveWorkflowChanged {
 	workflowId: Workflow['id'];
 }
 
+interface IWorkflowFailedToActivate {
+	workflowId: Workflow['id'];
+	errorMessage: string;
+}
+
 export interface IPushDataExecutionRecovered {
 	executionId: string;
 }

packages/cli/src/services/orchestration/main/MultiMainSetup.ee.ts

@@ -112,6 +112,7 @@ export class MultiMainSetup extends SingleMainSetup {
 		workflowId: string;
 		oldState: boolean;
 		newState: boolean;
+		versionId: string;
 	}) {
 		if (!this.sanityCheck()) return;
 
@@ -120,4 +121,13 @@ export class MultiMainSetup extends SingleMainSetup {
 			payload,
 		});
 	}
+
+	async broadcastWorkflowFailedToActivate(payload: { workflowId: string; errorMessage: string }) {
+		if (!this.sanityCheck()) return;
+
+		await this.redisPublisher.publishToCommandChannel({
+			command: 'workflowFailedToActivate',
+			payload,
+		});
+	}
 }

packages/cli/src/services/orchestration/main/handleCommandMessageMain.ts

@@ -7,6 +7,8 @@ import { License } from '@/License';
 import { Logger } from '@/Logger';
 import { ActiveWorkflowRunner } from '@/ActiveWorkflowRunner';
 import { Push } from '@/push';
+import { MultiMainSetup } from './MultiMainSetup.ee';
+import { WorkflowRepository } from '@/databases/repositories/workflow.repository';
 
 export async function handleCommandMessageMain(messageString: string) {
 	const queueModeId = config.getEnv('redis.queueModeId');
@@ -71,21 +73,36 @@ export async function handleCommandMessageMain(messageString: string) {
 					return message;
 				}
 
-				const { workflowId, oldState, newState } = message.payload ?? {};
+				const { workflowId, oldState, newState, versionId } = message.payload ?? {};
 
 				if (
 					typeof workflowId !== 'string' ||
 					typeof oldState !== 'boolean' ||
-					typeof newState !== 'boolean'
+					typeof newState !== 'boolean' ||
+					typeof versionId !== 'string'
 				) {
 					break;
 				}
 
 				const push = Container.get(Push);
 
 				if (!oldState && newState) {
-					await activeWorkflowRunner.add(workflowId, 'activate');
-					push.broadcast('workflowActivated', { workflowId });
+					try {
+						await activeWorkflowRunner.add(workflowId, 'activate');
+						push.broadcast('workflowActivated', { workflowId });
+					} catch (e) {
+						const error = e instanceof Error ? e : new Error(`${e}`);
+
+						await Container.get(WorkflowRepository).update(workflowId, {
+							active: false,
+							versionId,
+						});
+
+						await Container.get(MultiMainSetup).broadcastWorkflowFailedToActivate({
+							workflowId,
+							errorMessage: error.message,
+						});
+					}
 				} else if (oldState && !newState) {
 					await activeWorkflowRunner.remove(workflowId);
 					push.broadcast('workflowDeactivated', { workflowId });
@@ -97,6 +114,19 @@ export async function handleCommandMessageMain(messageString: string) {
 				await activeWorkflowRunner.removeActivationError(workflowId);
 			}
 
+			case 'workflowFailedToActivate': {
+				if (!debounceMessageReceiver(message, 100)) {
+					message.payload = { result: 'debounced' };
+					return message;
+				}
+
+				const { workflowId, errorMessage } = message.payload ?? {};
+
+				if (typeof workflowId !== 'string' || typeof errorMessage !== 'string') break;
+
+				Container.get(Push).broadcast('workflowFailedToActivate', { workflowId, errorMessage });
+			}
+
 			default:
 				break;
 		}

packages/cli/src/services/redis/RedisServiceCommands.ts

@@ -7,7 +7,8 @@ export type RedisServiceCommand =
 	| 'stopWorker'
 	| 'reloadLicense'
 	| 'reloadExternalSecretsProviders'
-	| 'workflowActiveStateChanged'; // multi-main only
+	| 'workflowActiveStateChanged' // multi-main only
+	| 'workflowFailedToActivate'; // multi-main only
 
 /**
  * An object to be sent via Redis pub/sub from the main process to the workers.

packages/cli/src/workflows/workflows.services.ts

@@ -382,6 +382,7 @@ export class WorkflowsService {
 					workflowId,
 					oldState,
 					newState: updatedWorkflow.active,
+					versionId: shared.workflow.versionId,
 				});
 			}
 		}

packages/editor-ui/src/Interface.ts

@@ -421,7 +421,8 @@ export type IPushData =
 	| PushDataExecutionRecovered
 	| PushDataWorkerStatusMessage
 	| PushDataActiveWorkflowAdded
-	| PushDataActiveWorkflowRemoved;
+	| PushDataActiveWorkflowRemoved
+	| PushDataWorkflowFailedToActivate;
 
 type PushDataActiveWorkflowAdded = {
 	data: IActiveWorkflowAdded;
@@ -433,6 +434,11 @@ type PushDataActiveWorkflowRemoved = {
 	type: 'workflowDeactivated';
 };
 
+type PushDataWorkflowFailedToActivate = {
+	data: IWorkflowFailedToActivate;
+	type: 'workflowFailedToActivate';
+};
+
 type PushDataExecutionRecovered = {
 	data: IPushDataExecutionRecovered;
 	type: 'executionRecovered';
@@ -509,6 +515,11 @@ export interface IActiveWorkflowRemoved {
 	workflowId: string;
 }
 
+export interface IWorkflowFailedToActivate {
+	workflowId: string;
+	errorMessage: string;
+}
+
 export interface IPushDataUnsavedExecutionFinished {
 	executionId: string;
 	data: { finished: true; stoppedAt: Date };

packages/editor-ui/src/mixins/pushConnection.ts

@@ -291,6 +291,20 @@ export const pushConnection = defineComponent({
 				}
 			}
 
+			if (receivedData.type === 'workflowFailedToActivate') {
+				this.workflowsStore.setWorkflowInactive(receivedData.data.workflowId);
+				this.workflowsStore.setActive(false);
+
+				this.showError(
+					new Error(receivedData.data.errorMessage),
+					this.$locale.baseText('workflowActivator.showError.title', {
+						interpolate: { newStateName: 'deactivated' },
+					}) + ':',
+				);
+
+				return true;
+			}
+
 			if (receivedData.type === 'workflowActivated') {
 				this.workflowsStore.setWorkflowActive(receivedData.data.workflowId);
 				return true;