ci: Switch to Node.js 20 by default. Add initial support for Node.js 22 #9501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
commented
May 23, 2024
n8n-assistant
bot
added
core
ivov
reviewed
May 24, 2024
| with: | ||
| node-version: 18.x | ||
| node-version: 20.x |
There was a problem hiding this comment.
Can we extract and reuse this step so we have a single spot to update?
There was a problem hiding this comment.
I want to do that in a separate PR. Started a while ago, but ran into some issues.
ivov
approved these changes
May 24, 2024
|
✅ All Cypress E2E specs passed |
2 flaky tests on run #5121 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9501 ↗︎
MiloradFilipovic
added a commit
that referenced
this pull request
May 24, 2024
* master: feat(core): Upgrade all langchain related dependencies (#9504) ci: Switch to Node.js 20 by default. Add initial support for Node.js 22 (#9501) fix(core): Prevent re-parsing of dynamically loaded options (#9503) fix(core): Fix `level` in `warn` method of error reporter (no-changelog) (#9502) # Conflicts: # packages/cli/package.json # packages/cli/src/requests.ts # pnpm-lock.yaml
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js 18.x went into maintenance October 2023, and 20.x has been the LTS since then.
We should switch over our setup also to default to 20.x, while still testing
masterCI on 18 and 22.PS: This does not change the minimum required version of node.js. That'll stay 18 until it goes EOL on 2025-04-30.
Review / Merge checklist