Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix level in warn method of error reporter (no-changelog) #9502

Merged
merged 1 commit into from
May 24, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented May 24, 2024

Passing an error-level error to the warn method of the error reporter causes it to be reported as an error-level error instead of as a warning, because the level is overridden. This is affecting some reports like Expression difference, errors reported by UserSubscriber, etc.

Ref: https://n8nio.slack.com/archives/C062YRE7EG4/p1716480235754399?thread_ts=1716474072.409529&cid=C062YRE7EG4

Passing an `error`-level error to the `warn` method of the error reporter
causes it to be reported as an `error`-level error instead of as a warning,
because the `level` is overridden. This is affecting some reports like
`Expression difference`, errors reported by `UserSubscriber`, etc.
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels May 24, 2024
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented May 24, 2024

2 flaky tests on run #5119 ↗︎

0 363 0 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project: n8n Commit: b8ab5b1589
Status: Passed Duration: 04:57 💡
Started: May 24, 2024 7:06 AM Ended: May 24, 2024 7:11 AM
Flakiness  cypress/e2e/5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video

Review all test suite changes for PR #9502 ↗︎

@ivov ivov merged commit 24e8ac0 into master May 24, 2024
28 checks passed
@ivov ivov deleted the fix-error-reporter-warn-level branch May 24, 2024 07:16
MiloradFilipovic added a commit that referenced this pull request May 24, 2024
* master:
  feat(core): Upgrade all langchain related dependencies (#9504)
  ci: Switch to Node.js 20 by default. Add initial support for Node.js 22 (#9501)
  fix(core): Prevent re-parsing of dynamically loaded options (#9503)
  fix(core): Fix `level` in `warn` method of error reporter (no-changelog) (#9502)

# Conflicts:
#	packages/cli/package.json
#	packages/cli/src/requests.ts
#	pnpm-lock.yaml
@janober
Copy link
Member

janober commented May 24, 2024

Got released with n8n@1.43.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants