feat: Add benchmark scope #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The benchmark scope is meant for the benchmark cli.
4 tasks
4 tasks
ivov
reviewed
Sep 2, 2024
| @@ -9,7 +9,7 @@ const TYPES = [ | |||
| "ci", | |||
| ]; | |||
|
|
|||
| const SCOPES = ["API", "core", "editor"]; | |||
| const SCOPES = ["API", "core", "editor", "benchmark"]; | |||
There was a problem hiding this comment.
- What is the criteria for adding a new scope instead of using
testorci? Existing scopes are broad whilebenchmarkseems granular. - If we decide to add a new scope, can we add a test?
There was a problem hiding this comment.
test and ci define the type of the commit, scope defined the component it is for. So we could have e.g. ci(benchmark). We could also consider the benchmarks to be just tests for the cli (i.e. always test(core)) or not use a scope at all. It is its own package and application, so I think it would make sense to have a separate scope for it.
ivov
approved these changes
Sep 2, 2024
|
Please remember this needs to be published for changes to take effect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benchmark scope is meant for the benchmark cli.