Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add benchmark scope #7

Merged
merged 2 commits into from
Sep 2, 2024
Merged

feat: Add benchmark scope #7

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59d09e4
feat: Add benchmark scope
tomi Aug 20, 2024
5901827
Add test for valid scopes
tomi Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const TYPES = [
"ci",
];

const SCOPES = ["API", "core", "editor"];
const SCOPES = ["API", "core", "editor", "benchmark"];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. What is the criteria for adding a new scope instead of using test or ci? Existing scopes are broad while benchmark seems granular.
  2. If we decide to add a new scope, can we add a test?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test and ci define the type of the commit, scope defined the component it is for. So we could have e.g. ci(benchmark). We could also consider the benchmarks to be just tests for the cli (i.e. always test(core)) or not use a scope at all. It is its own package and application, so I think it would make sense to have a separate scope for it.


const displayTypes = TYPES.map((type) => `\`${type}\``).join(", ");
const displayScopes = SCOPES.map((type) => `\`${type}\``).join(", ");
Expand Down
Loading