Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update clang-format to use v14 #9

Closed
2bndy5 opened this issue Jan 15, 2024 · 1 comment · Fixed by #11
Closed

update clang-format to use v14 #9

2bndy5 opened this issue Jan 15, 2024 · 1 comment · Fixed by #11

Comments

@2bndy5
Copy link
Member

2bndy5 commented Jan 15, 2024

I'm opening this here as the change will be applied here and affect all nRF24 repos.

I just noticed clang-format-12 is no longer available in apt PPA anymore (on Ubuntu).

sudo apt list clang-format*
Listing... Done
clang-format-13/mantic 1:13.0.1-13 amd64
clang-format-14/mantic 1:14.0.6-16 amd64
clang-format-15/mantic 1:15.0.7-10 amd64
clang-format-16/mantic 1:16.0.6-15 amd64
clang-format-17/mantic 1:17.0.2-1~exp1ubuntu2.1 amd64
clang-format/mantic 1:16.0-57 amd64

Looks like v16 is the default. Also, currently MSVC expects v16 or newer, so nRF24 devs running from Windows as their everyday OS can use the same clang tools required by other (up-to-date) projects that build on Windows.
@2bndy5
Copy link
Member Author

2bndy5 commented Jan 15, 2024

Note to self

Make Linux CI only run for

  • pushes to default branches (master branch in most nRF24 repos)
  • PR sync events when the PR targets the master branch

This will relax the CI failure notifications when a commit is pushed to non-default branch and said branch is not ready to PR into master.

@2bndy5 2bndy5 changed the title update clang-format to use v16 update clang-format to use v17 Feb 4, 2024
@2bndy5 2bndy5 mentioned this issue Feb 4, 2024
Merged
@2bndy5 2bndy5 changed the title update clang-format to use v17 update clang-format to use v16 Feb 16, 2024
2bndy5 added a commit to nRF24/RF24Network that referenced this issue Feb 16, 2024
@2bndy5
satisfy nRF24/.github#9
a521062
2bndy5 added a commit to nRF24/RF24Network that referenced this issue Feb 16, 2024
@2bndy5
satisfy nRF24/.github#9
3daa5cd
2bndy5 added a commit to nRF24/RF24Mesh that referenced this issue Feb 16, 2024
@2bndy5
satisfy nRF24/.github#9
6e9433e
2bndy5 added a commit to nRF24/RF24Mesh that referenced this issue Feb 16, 2024
@2bndy5
satisfy nRF24/.github#9
2fa3a10
2bndy5 added a commit to nRF24/RF24Ethernet that referenced this issue Feb 16, 2024
@2bndy5
satisfy nRF24/.github#9
144f4d5
2bndy5 added a commit to nRF24/RF24Gateway that referenced this issue Feb 16, 2024
@2bndy5
satisfy nRF24/.github#9
bfa78c6
2bndy5 added a commit to nRF24/pyRF24 that referenced this issue Feb 16, 2024
@2bndy5
satisfy nRF24/.github#9
06f83d5
2bndy5 added a commit to nRF24/RF24 that referenced this issue Feb 16, 2024
@2bndy5
satisfy nRF24/.github#9
7214569
@2bndy5 2bndy5 mentioned this issue Feb 16, 2024
Merged
2bndy5 added a commit to nRF24/RF24 that referenced this issue Feb 17, 2024
@2bndy5
Update clang format (#940)
4b7ab9c 
* satisfy nRF24/.github#9
* ran clang-format
* use a separate workflow to check code format
* disable ATTinyCore in Arduino CI
  currently too much headache from upstream problems (namely in Arduino CLI tool)
* reduce duplicate CI triggers
* add dependabot to update CI dependencies
2bndy5 added a commit to nRF24/RF24Network that referenced this issue Feb 17, 2024
@2bndy5
satisfy nRF24/.github#9
7b094a0
2bndy5 added a commit to nRF24/RF24Network that referenced this issue Feb 17, 2024
@2bndy5
satisfy nRF24/.github#9
3eb9cfc
@2bndy5 2bndy5 mentioned this issue Feb 17, 2024
Merged
@2bndy5 2bndy5 changed the title update clang-format to use v16 update clang-format to use v14 Feb 17, 2024
This was referenced Feb 17, 2024
Merged
Merged
2bndy5 added a commit to nRF24/pyRF24 that referenced this issue Feb 20, 2024
@2bndy5
Update clang format (#35)
be0bc2b 
* satisfy nRF24/.github#9
* [docs CI] install libgl directly
2bndy5 added a commit to nRF24/RF24Network that referenced this issue Feb 20, 2024
@2bndy5
Update clang format (#219)
3a29ab9 
* satisfy nRF24/.github#9
* ran clang-format
* use a separate workflow to check code formatting
* enable dependabot
2bndy5 added a commit to nRF24/RF24Network that referenced this issue Feb 20, 2024
@2bndy5
1.x update clang format (#220)
b5564c1 
* satisfy nRF24/.github#9
* ran clang-format
* use separate CI workflow to check code format
* enable dependabot
This was referenced Feb 20, 2024
Merged
Merged
Merged
Merged
Merged
2bndy5 added a commit to nRF24/RF24Gateway that referenced this issue Feb 20, 2024
@2bndy5
Update clang format (#30)
b4eb4c6 
* satisfy nRF24/.github#9
* ran clang-format
* use a separate workflow to check code format
* enable dependabot
2bndy5 added a commit to nRF24/RF24Mesh that referenced this issue Feb 20, 2024
@2bndy5
satisfy nRF24/.github#9
b035a76
2bndy5 added a commit to nRF24/RF24Mesh that referenced this issue Feb 20, 2024
@2bndy5
satisfy nRF24/.github#9
7785a8e
2bndy5 added a commit to nRF24/RF24Mesh that referenced this issue Feb 20, 2024
@2bndy5
1.x update clang format (#232)
d188e64 
* satisfy nRF24/.github#9
* ran clang-format
* use separate CI workflow to check code format
* enable dependabot
2bndy5 added a commit to nRF24/RF24Mesh that referenced this issue Feb 20, 2024
@2bndy5
Update clang format (#231)
e0d390c 
* satisfy nRF24/.github#9
* ran clang-format
* use separate CI workflow to check code format
* enable dependabot
2bndy5 added a commit to nRF24/RF24Ethernet that referenced this issue Feb 21, 2024
@2bndy5
satisfy nRF24/.github#9
0220e8b
2bndy5 added a commit to nRF24/RF24Ethernet that referenced this issue Feb 21, 2024
@2bndy5
Update clang format (#41)
97a2c73 
* satisfy nRF24/.github#9
* ran clang-format
* use separate workflow to check code format
* enable dependabot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

switch to clang-format v14 nRF24/.github
1 participant
@2bndy5