-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to clang-format v14 #11
Conversation
This feature (of cpp-linter python package) will produce a PR review with a patch (to fix format problems) in the review's summary comment and include applicable fixes as @TMRh20 This one is for you mostly, but it will be a help to anyone that doesn't understand what the CI is trying to say about code formatting. PS - Having the CI fix formatting and push changes automatically is on my radar (for the cpp-linter pkg), but I have to be mindful of the write access that idea requires. |
7e32683
to
71f417d
Compare
e544d35
to
e5f6af0
Compare
uses cpp-linter v1.7.1 for the new PR review feature (`--format-review` arg) cpp-linter needs a token to post PR reviews/comments
e5f6af0
to
7846dea
Compare
I'm ready to merge this, but I want to wait till nRF24/RF24Network#218 is merged first. pushing this change to main will also instigate a crusade of PRs to update the .clang-format config files in all repos. I have created branches in all repos for the upcoming format crusade. |
Updates reusable CI workflow that checks code formatting.
cpp-linter --format-review
).Also updates the guideline explanations as some (useful) options were only applicable to v13+.
Note
Updates to all nRF24 org repo's .clang-format file is required for consistency.
closes #9