Fix testthat error on xlex class #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`xlex()` returns a tibble with an extra class `"xlex"` for `print.xlex()`. This extra class is now detected by `testthat::expect_equal()` when comparing it to a contrived tibble. The tests now use a wrapper of `xlex()` called `un_xlex()` that strips the `"xlex"` class so that it can be safely compared with a tibble. Alternatively, I could have defined a wrapper class for `tribble()` that added the extra class, but it would have been more trouble to format the code nicely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xlex()returns a tibble with an extra class"xlex"forprint.xlex(). Thisextra class is now detected by
testthat::expect_equal()when comparing it to acontrived tibble.
The tests now use a wrapper of
xlex()calledun_xlex()that strips the"xlex"class so that it can be safely compared with a tibble.Alternatively, I could have defined a wrapper class for
tribble()that addedthe extra class, but it would have been more trouble to format the code nicely.