Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix testthat error on xlex class #57

Merged
merged 3 commits into from
Mar 20, 2020
Merged

Fix testthat error on xlex class #57

merged 3 commits into from
Mar 20, 2020

Commits on Mar 20, 2020

  1. Fix testthat error on xlex class 

    `xlex()` returns a tibble with an extra class `"xlex"` for `print.xlex()`.  This
extra class is now detected by `testthat::expect_equal()` when comparing it to a
contrived tibble.

The tests now use a wrapper of `xlex()` called `un_xlex()` that strips the
`"xlex"` class so that it can be safely compared with a tibble.

Alternatively, I could have defined a wrapper class for `tribble()` that added
the extra class, but it would have been more trouble to format the code nicely.
    @nacnudus
    nacnudus committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    0ee4ef7 View commit details
    Browse the repository at this point in the history

  2. Increment version number

    @nacnudus
    nacnudus committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    8dc1c09 View commit details
    Browse the repository at this point in the history

  3. NEWS

    @nacnudus
    nacnudus committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    3b1f73d View commit details
    Browse the repository at this point in the history