Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support keepalive options #30

Closed
1 task
nakabonne opened this issue Oct 2, 2020 · 3 comments
Closed
1 task

Support keepalive options #30

nakabonne opened this issue Oct 2, 2020 · 3 comments
Labels
good first issue Good for newcomers

Comments

@nakabonne
Copy link
Owner

nakabonne commented Oct 2, 2020 •
edited
Loading

  • Enable to switch to use persistent connections

Only tiny changes are required because all we have to do is just pass to the Vegeta API.
@nakabonne nakabonne added the good first issue Good for newcomers label Oct 2, 2020
@cvhariharan
Copy link
Contributor

Hi, I can pick this up if this is still open 😄

@nakabonne
Copy link
Owner Author

@cvhariharan Hi, glad you're interested in it! That would be nice, look forward to your PR.

nakabonne added a commit that referenced this issue Oct 4, 2020
@nakabonne
Merge pull request #43 from cvhariharan/master
e963eff 
Add keepalive flag. Fixes issue #30
@nakabonne
Copy link
Owner Author

Closing since this is resolved by #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cvhariharan @nakabonne