Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keepalive flag. Fixes issue #30 #43

Merged
merged 1 commit into from
Oct 4, 2020
Merged

Add keepalive flag. Fixes issue #30 #43

merged 1 commit into from
Oct 4, 2020

Conversation

cvhariharan
Copy link
Contributor

Adds a new boolean flag -K or --keepalive to use persistent connections for the requests.

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2020

Codecov Report

Merging #43 into master will decrease coverage by 0.33%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   72.07%   71.75%   -0.32%     
==========================================
  Files           8        8              
  Lines         358      361       +3     
==========================================
+ Hits          258      259       +1     
- Misses         82       84       +2     
  Partials       18       18              
Impacted Files Coverage Δ
attacker/attacker.go 69.45% <0.00%> (-1.98%) ⬇️
main.go 55.92% <88.89%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ad170f...6f10403. Read the comment docs.

@nakabonne
Copy link
Owner

@cvhariharan Hey, thank you for your contribution!

@nakabonne nakabonne merged commit e963eff into nakabonne:master Oct 4, 2020
@nakabonne nakabonne mentioned this pull request Oct 4, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants