Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FromBase64 #145

Merged
merged 6 commits into from
Jun 7, 2021
Merged

Fix FromBase64 #145

merged 6 commits into from
Jun 7, 2021

Conversation

josesimoes
Copy link
Member

Description

  • Improve efficiency by using string instead of char.
  • Rework native call to use string.
  • Bump native version to 100.5.0.11.
  • Add unit tests.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@josesimoes josesimoes mentioned this pull request Jun 7, 2021
Merged
13 tasks
@josesimoes
Fix FromBase64
95b9b09 
- Improve efficiency by using string instead of char.
- Rework native call to use string.
- Bump native version to 100.5.0.11.
- Add unit tests.
@josesimoes josesimoes force-pushed the fix-773 branch 5 times, most recently from 5ef3b5f to 5b2355e Compare June 7, 2021 16:57
@josesimoes
Work CI-CD
6753a52 
- Add build steps for Test Framework.
- Update test framework sub-module @ 8971e8e.
josesimoes added 2 commits June 7, 2021 18:28
@josesimoes
Work CI-CD
aed1dd6 
- Add build steps for Test Framework.
- Update test framework sub-module @ 8971e8e.
- Fix deployment projects for mscorlib.
@josesimoes
Add import project to all unit test projects
a086229
@josesimoes josesimoes merged commit 1d7f1e8 into nanoframework:develop Jun 7, 2021
@josesimoes josesimoes deleted the fix-773 branch June 7, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: bug Type: Unit Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert.ToBase64String is not working properly
2 participants
@josesimoes @nfbot