Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FromBase64 #1944

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Fix FromBase64 #1944

merged 1 commit into from
Jun 7, 2021

Conversation

josesimoes
Copy link
Member

Description

  • Replace FromChar with FromString implementation.
  • Update mscorlib declarations.

Motivation and Context

How Has This Been Tested?

  • Unit Tests in mscorlib.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@josesimoes
Fix FromBase64
9a54e5c 
- Replace FromChar with FromString implementation.
- Update mscorlib declarations.
@nfbot nfbot added Type: bug Type: dependencies Pull requests that update a dependency file(s) or version labels Jun 7, 2021
@josesimoes josesimoes merged commit 3c807e8 into nanoframework:develop Jun 7, 2021
@josesimoes josesimoes deleted the fix-773 branch June 7, 2021 10:47
@josesimoes josesimoes added the Area: Common libs Everything related with common libraries label Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Type: bug Type: dependencies Pull requests that update a dependency file(s) or version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot