Add System.Devices.Dac #1396
Merged
Add System.Devices.Dac #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github.com/nanoframework/ChibiOS/tree/master/testhal/STM32/multi/DAC can be used as a sample if it helps someone...
- Rework code to move vars declaration to the top of the functions. - Update declaration of native assembly. - Tweak headers inclusion. - Fix comment on include guards. Signed-off-by: José Simões <jose.simoes@eclo.solutions>
Signed-off-by: José Simões <jose.simoes@eclo.solutions>
Signed-off-by: José Simões <jose.simoes@eclo.solutions>
Signed-off-by: José Simões <jose.simoes@eclo.solutions>
Signed-off-by: José Simões <jose.simoes@eclo.solutions>
- Update assembly declaration. - Implement NativeDispose for DacChannel. Signed-off-by: José Simões <jose.simoes@eclo.solutions>
- Correct function and struct names. Signed-off-by: José Simões <jose.simoes@eclo.solutions>
- Need to save driver and channel number. - Need to add PAL DAC structure to persist DAC configuration struct. - Add DAC config on all reference targets. - Update halconf for DAC on all reference targets. - Update mcuconf for DAC on all reference targets that support it. Signed-off-by: José Simões <jose.simoes@eclo.solutions>
- Replace samples buffer to output DAC value with call to dacPutChannelX Signed-off-by: José Simões <jose.simoes@eclo.solutions>
josesimoes
added
Series: STM32xx
|
Hi @josesimoes, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.