Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default serial baud rate #1416

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Update default serial baud rate #1416

merged 1 commit into from
Jul 23, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Update default serial baud rate on all targets to 921600.

Motivation and Context

  • Support change in Update serial baud rate to 921600 nf-debugger#204.
  • All current targets support this baud rate without any problem. This increases Wire Protocol throughput ~8x.
  • Transport is actually performed with USB, serial is only used on very short distance on the board, meaning that no transmission issue will raise from this. Even if that's the case the WP layer has error checking mechanism that can be used to detect this, if needed.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes josesimoes added Series: STM32xx Everything related specifically with STM32 targets Series: ESP32 Everything related specifically with ESP32 series targets Breaking-change Series: TI-CC32xx labels Jul 23, 2019
@nfbot
Copy link
Member

nfbot commented Jul 23, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

josesimoes added a commit to nanoframework/nf-Community-Targets that referenced this pull request Jul 23, 2019
@josesimoes
Update serial baud rate to 921600
c9b8cc5 
- Following nanoframework/nf-interpreter#1416.

***ALL***

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes mentioned this pull request Jul 23, 2019
Merged
@josesimoes josesimoes force-pushed the update-serial-baudrate branch from 1f6ca93 to 6f6807b Compare July 23, 2019 17:07
@josesimoes
Update default serial baud rate
4a149db 
Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes force-pushed the update-serial-baudrate branch from 6f6807b to 4a149db Compare July 23, 2019 17:09
AdrianSoundy
AdrianSoundy approved these changes Jul 23, 2019
View reviewed changes
Copy link
Member

@AdrianSoundy AdrianSoundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdrianSoundy
Copy link
Member

AdrianSoundy commented Jul 23, 2019 •
edited
Loading

Seeing this is a breaking change i thought i would hold off merge until i have tested it with esp32
Unless you have already tested then go ahead and merge.

@josesimoes
Copy link
Member Author

Yes, I've tested extensively.
It required several fixes on the debugger and also VS extension.
Was waiting for the last VS extension version for a final round of testing.

@josesimoes josesimoes merged commit cfc8413 into nanoframework:develop Jul 23, 2019
@josesimoes josesimoes deleted the update-serial-baudrate branch July 23, 2019 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrianSoundy AdrianSoundy AdrianSoundy approved these changes

Assignees
No one assigned
Labels
Breaking-change Series: ESP32 Everything related specifically with ESP32 series targets Series: STM32xx Everything related specifically with STM32 targets Series: TI-CC32xx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josesimoes @nfbot @AdrianSoundy