Fix time conversion issues in PAL events #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @martin-kuhn, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
josesimoes
added
Platform: STM32
josesimoes
reviewed
Feb 26, 2020
|
Looks good on infinite loop testing. Here's s screeshot from the scope output for a toggle on an infinite loop with 125ms. |
|
Running the timer sample shows some curious results:
🤔 this smells like a watchdog issue.... |
|
Care to merge the latest changes from develop branch please so this can be merged? |
|
Yes, it's done. |
josesimoes
changed the title
josesimoes
added a commit
to Eclo/nf-interpreter
that referenced
this pull request
Mar 10, 2020
- Port changes from nanoframework#1566 to ESP32, NXP and TI platforms. - Improve check of "no delay" condition and dequeue and execute immediately instead of calling the timer API just because. Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
10 tasks
josesimoes
added a commit
to Eclo/nf-interpreter
that referenced
this pull request
Mar 10, 2020
- After the fix with nanoframework#1566 STM32 targets where rebooting on idle. The reason was the watchdog kicking in as the wait now happens inside the Events_WaitForEvents loop. Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Debug checks showed, that the chVTSet method is always called with a delay of zero, which should not be done.
The delay of zero was caused by dividing the ticks value by TIME_CONVERSION__TO_MILLISECONDS (=10000) which is not necessary. The compareValueTicks is already in CMSIS Ticks there, which is equal to milliseconds.
We also have to use the HAL_Time_CurrentSysTicks() method wherever the value is in CMSIS ticks instead of the HAL_Time_CurrentTime() method which returns a value in .NET ticks.
How Has This Been Tested?
This has been tested on a custom STM32F427 based MCU board.
Types of changes
Checklist:
Signed-off-by: Martin Kuhn martin.kuhn@csa.ch