Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix events and timer compare #1581

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Fix events and timer compare #1581

merged 1 commit into from
Mar 10, 2020

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Mar 10, 2020 •
edited
Loading

Description

Motivation and Context

  • ESP32, NXP and TI platforms where missing this fix.
  • Improvement in the "0 delay" condition.

How Has This Been Tested?

  • Blinky app.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

cc @martin-kuhn
cc @AdrianSoundy
cc @MateuszKlatecki

@josesimoes
Fix events and timer compare
ece6e7a 
- Port changes from nanoframework#1566 to ESP32, NXP and TI platforms.
- Improve check of "no delay" condition and dequeue and execute immediately instead of calling the timer API just because.

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@nfbot
Copy link
Member

nfbot commented Mar 10, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Series: ESP32 Everything related specifically with ESP32 series targets Series: NXP i6 Everything related specifically with NXP targets Series: STM32xx Everything related specifically with STM32 targets Series: TI-CC13x2_26x2 Type: bug labels Mar 10, 2020
@josesimoes josesimoes merged commit 7927f67 into nanoframework:develop Mar 10, 2020
@josesimoes josesimoes deleted the fix-events-time branch March 10, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Series: NXP i6 Everything related specifically with NXP targets Series: STM32xx Everything related specifically with STM32 targets Series: TI-CC13x2_26x2 Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot