Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in block storage and target definitions #1838

Merged
merged 2 commits into from
Mar 1, 2021

Conversation

josesimoes
Copy link
Member

Description

  • Rework BlockStorage tables to make it clear that those are coming from the partition table.
  • Remove unused vars.
  • Improve comments on several places related with these configs and reasoning for them.
  • Update code to follow project code style.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Rework BlockStorage tables to make it clear that those are comming from the partition table.
- Remove unused vars.
- Improve comments on several places related with these configs and reasoning for them.
- Update code to follow project code style.
@josesimoes josesimoes added the Series: ESP32 Everything related specifically with ESP32 series targets label Feb 16, 2021
@josesimoes josesimoes merged commit f5fc3fc into nanoframework:develop Mar 1, 2021
@josesimoes josesimoes deleted the esp32-block-storage branch March 1, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants