Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in TRACE for Wire Protocol #2039

Merged
merged 2 commits into from
Sep 9, 2021
Merged

Conversation

josesimoes
Copy link
Member

Description

  • Define single method used to TRACE WP headers and replace the copy-paste with single macro to call the method and ensure uniform traced output when debugging WP message exchanges.
  • Remove TRACE calls from debugger class.

Motivation and Context

  • Uniform trace data that matches data traced by Debugger on PC. Additional data formatting in a way that is easier to read.
  • On debugger class the TRACE usage wasn't bringing much value.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented Sep 9, 2021

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit d83665a into develop Sep 9, 2021
@josesimoes josesimoes deleted the cleanup-rework--trace branch September 9, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants