Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for USB connection issues with F769I #388

Merged
merged 8 commits into from
Jul 9, 2017
Merged

fix for USB connection issues with F769I #388

merged 8 commits into from
Jul 9, 2017

Conversation

networkfusion
Copy link
Member

No description provided.

@nfbot
Copy link
Member

nfbot commented Jul 7, 2017

Hi @networkfusion,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@piwi1263
Copy link
Member

piwi1263 commented Jul 7, 2017 •
edited
Loading

You're sure you want the OTG1, OTG2 settings in mcuconf.h in both booter and clr different ?

@josesimoes
Copy link
Member

If there is a good reason for this, there is nothing fundamentally wrong with it...
Booter and CLR can behave differently if required. That's why they are designed to be completely separate entities. @networkfusion will tell if that's on purpose or not.

@piwi1263
Copy link
Member

piwi1263 commented Jul 8, 2017

That's why I asked.

@networkfusion
Copy link
Member Author

Kind of because the St port is listed as FS... But i have disabled it in my current code as well as changing some of the static fields to be USB2. I will push it when at my laptop. It doesn't fix the fact that deployment still fails though...

@networkfusion
Copy link
Member Author

hoping I have rebased correctly... please let me know if not?!

piwi1263
piwi1263 approved these changes Jul 9, 2017
View reviewed changes
Copy link
Member

@piwi1263 piwi1263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good enough to me.

@piwi1263 piwi1263 merged commit 8326c0b into nanoframework:master Jul 9, 2017
@networkfusion networkfusion deleted the f7usb branch July 27, 2017 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piwi1263 piwi1263 piwi1263 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@networkfusion @nfbot @piwi1263 @josesimoes