Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to documentation (#386) #389

Merged
merged 1 commit into from
Jul 8, 2017
Merged

updates to documentation (#386) #389

merged 1 commit into from
Jul 8, 2017

Conversation

networkfusion
Copy link
Member

No description provided.

@nfbot
Copy link
Member

nfbot commented Jul 7, 2017

Hi @networkfusion,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@ghost
Copy link

ghost commented Jul 7, 2017

Not directlly related to your PR, but don't you think that we should use the same "on/off" switches for options ?
Some are using TRUE/FALSE while some others are using ON/OFF.

@josesimoes
Copy link
Member

@MikroBusNet I understand what you are saying. This is related with #312 . There are options (in CMake) that are on/off buy most of the existing ones are using true/false because the author ( 😉 ) want knowledgeable about those...

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@josesimoes josesimoes merged commit 272a2bd into nanoframework:master Jul 8, 2017
MatthiasJentsch added a commit that referenced this pull request Sep 9, 2018
… SerialCommunication (#846)

To not confuse the source level debugger (C# debugger) it's safer to output the data in GenericPort_Write
only if the program is in running state without any other flags (without the debugger).

Signed-off-by: Matthias Jentsch <info@matthias-jentsch.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants