Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Unable to start debug session on ESP32 when using SerialCommunication #846

Merged
merged 2 commits into from
Sep 9, 2018
Merged

Fix: Unable to start debug session on ESP32 when using SerialCommunication #846

merged 2 commits into from
Sep 9, 2018

Conversation

MatthiasJentsch
Copy link
Contributor

Description

To not confuse the source level debugger (C# debugger) it's safer to output the data in GenericPort_Write
only if the program is in running state without any other flags (without the debugger).

Motivation and Context

How Has This Been Tested?

Tested with SerialCommunication example and simple Hello World C# program. Both are working.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Matthias Jentsch info@matthias-jentsch.de

@MatthiasJentsch
Fix for issue #389: Unable to start debug session on ESP32 when using…
ee14a21 
… SerialCommunication

To not confuse the source level debugger (C# debugger) it's safer to output the data in GenericPort_Write
only if the program is in running state without any other flags (without the debugger).

Signed-off-by: Matthias Jentsch <info@matthias-jentsch.de>
@nfbot
Copy link
Member

nfbot commented Sep 8, 2018

Hi @MatthiasJentsch,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

josesimoes
josesimoes approved these changes Sep 9, 2018
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a nice workaround! Let's stick with this one unless anyone finds a better approach. 🏅

@josesimoes josesimoes added Type: enhancement Series: ESP32 Everything related specifically with ESP32 series targets labels Sep 9, 2018
@MatthiasJentsch MatthiasJentsch merged commit 75a9c8b into nanoframework:develop Sep 9, 2018
@MatthiasJentsch MatthiasJentsch deleted the Fix389 branch September 9, 2018 21:28
@Henrik98 Henrik98 mentioned this pull request Oct 19, 2021
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

@AdrianSoundy AdrianSoundy Awaiting requested review from AdrianSoundy

Assignees
No one assigned
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to start debug session on ESP32 when using SerialCommunication
3 participants
@MatthiasJentsch @nfbot @josesimoes