Various board updates for Netduino 3 Wifi #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is cummulative change including the following topics: - Add support for ADC - Activate SPI2 on the Arduino pins - Active USART6 on the Arduino pins - Naming change on the build outcome Signed-off-by: piwi1263 <piwi1263@gmail.com>
|
Hi @piwi1263, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
josesimoes
reviewed
Mar 28, 2018
| @@ -207,7 +212,7 @@ if(HEX2DFU_TOOL_AVAILABLE) | |||
| NF_GENERATE_DFU_PACKAGE( | |||
| ${PROJECT_SOURCE_DIR}/build/${NANOBOOTER_PROJECT_NAME}.bin 08000000 | |||
| ${PROJECT_SOURCE_DIR}/build/${NANOCLR_PROJECT_NAME}.bin 08008000 | |||
| ${PROJECT_SOURCE_DIR}/build/nanobooter-nanoclr.dfu | |||
| ${PROJECT_SOURCE_DIR}/build/nanoframework-4-netduino3wifi.dfu | |||
There was a problem hiding this comment.
Any particular reason for changing to this name?
There was a problem hiding this comment.
Yes. If you have multiple outcomes from various boards it is of convenience to distinct the names. Plus after a certain amount of time you can't guess purely on the name for what board that one or more files were.
josesimoes
added
Type: enhancement
Series: STM32xx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is cummulative change including the following:
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist:
Signed-off-by: piwi1263 piwi1263@gmail.com