add footer #170
add footer #170
Conversation
| export interface IconPropsColor extends IconProps { | ||
| color?: string; | ||
| } |
There was a problem hiding this comment.
This will conflict with my changes in #168, but I like this approach better so that only icons that support changing the color can use it. Although, I imagine if we get to the point where every icon has this prop, we'll be able to consolidate it with the IconProps interface.
One thing is I would name this IconColorProps to be consistent with how prop interfaces are named and I find it more natural that Icon and Color are next to each other since that's what the interface does
There was a problem hiding this comment.
Overall LGTM! Left one comment about the interface.
I would say let's merge this before #168 so I can get the IconColorProps interface
There was a problem hiding this comment.
Could you also update the links pls. We found broken and copy-and-pasted link during the bug bash:
https://airtable.com/shr6MXADGlNNaohN7/tblKHsTqQzLZW70S9/viwhDGIqzDkq0EprV/rec5BrtMb8BEdhugP
theme/src/components/Footer.tsx
Outdated
| const COMMON_STYLES = clsx( | ||
| 'text-xs screen-450:text-sm text-white', | ||
| 'whitespace-nowrap mr-6 last:mr-0', | ||
| ); |
There was a problem hiding this comment.
sorry if there wasn't autocomplete for this, i need to add a Taiwind autocomplete pattern for this use case 😭
theme/src/components/Footer.tsx
Outdated
| }, | ||
| { | ||
| title: 'Twitter', | ||
| link: 'https://twitter.com/napari-imaging', |
There was a problem hiding this comment.
it should be an underscore lol
theme/src/components/Footer.tsx
Outdated
| }, | ||
| { | ||
| title: 'Zulip', | ||
| link: 'https://image.sc', |
There was a problem hiding this comment.
Could you update this with the zulip link pls
* `color` prop for icon * Refactor GridTableOfContents to use icon color prop * `gridTOC` frontmatter data * GridTableOfContents component * Use GridTableOfContents in App * Use $min-font-size in global.scss * Fix styling for grid TOC * Rename GridTableOfContents to QuickLinks * Remove demo data * Fix quick links grid gap * `metaDescription` config for setting meta description tag * Fix _modules link on API references * Inline code styling copied from napari hub * Add custom Pygments code theme * Load scripts and stylesheets from HTML file * Fix styling for copy button * Add comments * Fix theme colors to be a11y friendly * Fix sphinx script loading for pages transitions * Use IconColorProps from #170
* main: Theme fixes and more (napari#169) Landing page quick links (napari#168) Fix docs deployment
|
note that adding the napari hub logo messes up some of the styling. I've talked with lia and we've decided to address this later |
Sounds good to me! I'll also reduce the priority of https://airtable.com/shrh6xgDr4WOIWJ6v/tblKHsTqQzLZW70S9/viwF28gahcRIbKSJ9/reclC9lrwm4sHhIRx |
Figma
