-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert command success events to INFORMATION type #107
Comments
@skliper Yes - they should be That would align with the cFE Developer's Guide s7.2. Also, see the reasoning provided here which makes a lot of sense. Side note: for the Reset command in particular, most implementations currently keep that as the single command that is |
…s-events-to-info Fix #107, Convert command success events to `INFORMATION` type
Checklist (Please check before submitting)
Is your feature request related to a problem? Please describe.
Command success events in DS are
CFE_EVS_EventType_DEBUG
, example:DS/fsw/inc/ds_events.h
Lines 284 to 287 in 6418164
DS/fsw/src/ds_cmds.c
Line 106 in 6418164
cFE pattern (AFAIK) is event success creates
CFE_EVS_EventType_INFORMATION
.Describe the solution you'd like
Since these are triggered by command only, flooding isn't anticipated and it's useful to see the event nominally. Would then match nominal pattern in cFE.
Describe alternatives you've considered
Change all command success responses to DEBUG, or even add a new command success type. Consistency is key.
Additional context
In concert w/ reporting time stamps in event messages, this makes it easier to quickly verify RTS timing/behavior. Even without it in the log, the time tagged event messages provide a similar benefit.
Requester Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered: