Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert command success events to INFORMATION type #107

Closed
3 tasks done
skliper opened this issue Apr 27, 2023 · 1 comment · Fixed by #110
Closed
3 tasks done

Convert command success events to INFORMATION type #107

skliper opened this issue Apr 27, 2023 · 1 comment · Fixed by #110

Comments

@skliper
Copy link
Contributor

skliper commented Apr 27, 2023

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
Command success events in DS are CFE_EVS_EventType_DEBUG, example:

DS/fsw/inc/ds_events.h

Lines 284 to 287 in 6418164

/**
* \brief DS Reset Counters Command Event ID
*
* \par Type: DEBUG

CFE_EVS_SendEvent(DS_RESET_CMD_EID, CFE_EVS_EventType_DEBUG, "Reset counters command");

cFE pattern (AFAIK) is event success creates CFE_EVS_EventType_INFORMATION.

Describe the solution you'd like
Since these are triggered by command only, flooding isn't anticipated and it's useful to see the event nominally. Would then match nominal pattern in cFE.

Describe alternatives you've considered
Change all command success responses to DEBUG, or even add a new command success type. Consistency is key.

Additional context
In concert w/ reporting time stamps in event messages, this makes it easier to quickly verify RTS timing/behavior. Even without it in the log, the time tagged event messages provide a similar benefit.

Requester Info
Jacob Hageman - NASA/GSFC

@thnkslprpt
Copy link
Contributor

thnkslprpt commented May 3, 2023

@skliper Yes - they should be INFO, not DEBUG. It is indeed the nominal pattern across cFE/cFS although currently there are a couple of other apps that don't comply, and a couple of cFE components that only partially comply.

That would align with the cFE Developer's Guide s7.2. Also, see the reasoning provided here which makes a lot of sense.

Side note: for the Reset command in particular, most implementations currently keep that as the single command that is DEBUG type, but I don't see why that should remain the case - one would probably still want to be informed the Reset command occurred successfully when DEBUG events are turned off.

thnkslprpt added a commit to thnkslprpt/DS that referenced this issue May 7, 2023
thnkslprpt added a commit to thnkslprpt/DS that referenced this issue May 7, 2023
thnkslprpt added a commit to thnkslprpt/DS that referenced this issue May 28, 2023
dzbaker added a commit that referenced this issue Jun 8, 2023
…s-events-to-info

Fix #107, Convert command success events to `INFORMATION` type
@dmknutsen dmknutsen added this to the Equuleus milestone Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants