-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-distinct identifiers static analysis warning #115
Comments
2 more instances in the same file that differ only in case (capitalization): Lines 1116 to 1118 in 2a6c6a2
Lines 1214 to 1216 in 2a6c6a2
|
chillfig
pushed a commit
to chillfig/DS
that referenced
this issue
Jan 23, 2024
2 tasks
dzbaker
added a commit
that referenced
this issue
Feb 1, 2024
Fix #115, Adds distinct identifiers from command name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist (Please check before submitting)
Describe the bug
DS_CloseFileCmd conflict here:
DS/fsw/src/ds_cmds.c
Lines 963 to 965 in 2a6c6a2
To Reproduce
Static analysis
Expected behavior
Unique identifiers. TBH calling this variable a Cmd is misleading, it's a pointer to the payload. Suggest changing to PayloadPtr for all of these command processing routines (which would resolve this issue as well).
System observed on:
CodeSonar static analysis
Additional context
None
Reporter Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered: