Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #115, Adds distinct identifiers from command name #123

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

chillfig
Copy link
Contributor

@chillfig chillfig commented Jan 23, 2024

Checklist (Please check before submitting)

Describe the contribution

Testing performed
CodeSonar, local build, lcov, and cert_testbed functional tests
Screenshot 2024-02-01 at 1 03 12 PM

Expected behavior changes
No impact to behavior

System(s) tested on

  • OS: Ubuntu 20.04

Additional context
Nondistinct ID warning is no longer showing in ds_cmds.c. Nonetheless, these changes make sense in the context of making the identifier names consistent across cFS apps.

Third party code
N/A

Contributor Info - All information REQUIRED for consideration of pull request
Justin Figueroa, Vantage Systems

@@ -1145,7 +1145,7 @@
CFE_EVS_SendEvent(DS_ADD_MID_CMD_ERR_EID, CFE_EVS_EventType_ERROR,
"Invalid ADD MID command: filter table is not loaded");
}
else if ((FilterTableIndex = DS_TableFindMsgID(DS_AddMidCmd->MessageID)) != DS_INDEX_NONE)
else if ((FilterTableIndex = DS_TableFindMsgID(PayloadPtr->MessageID)) != DS_INDEX_NONE)

Check warning

Code scanning / CodeQL

Side effect in a Boolean expression Warning

This Boolean expression is not side-effect free.
@dzbaker dzbaker merged commit fe2ea87 into nasa:main Feb 1, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-distinct identifiers static analysis warning
3 participants