Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize status in CFE_ES_WaitForSystemState #1071

Closed
skliper opened this issue Jan 6, 2021 · 1 comment · Fixed by #1115 or #1150
Closed

Initialize status in CFE_ES_WaitForSystemState #1071

skliper opened this issue Jan 6, 2021 · 1 comment · Fixed by #1115 or #1150
Labels
bug
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Jan 6, 2021

Is your feature request related to a problem? Please describe.
From LGTM: The variable Status may not be initialized here.

cFE/fsw/cfe-core/src/es/cfe_es_api.c

Line 640 in 56397a3

return Status;

Describe the solution you'd like
Initialize to success

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@skliper
Copy link
Contributor Author

skliper commented Jan 6, 2021

Confirm UT checks for success return. A little surprised this wouldn't have failed.

@skliper skliper added this to the 7.0.0 milestone Jan 22, 2021
skliper added a commit to skliper/cFE that referenced this issue Jan 22, 2021
@skliper
Fix nasa#1071, Initialize Status in CFE_ES_WaitForSystemState
8841e77
@skliper skliper added bug and removed enhancement labels Jan 22, 2021
@skliper skliper mentioned this issue Jan 22, 2021
Merged
skliper added a commit to skliper/cFE that referenced this issue Jan 27, 2021
@skliper
Fix nasa#1071, Initialize Status in CFE_ES_WaitForSystemState
1def3b5
astrogeco added a commit that referenced this issue Feb 3, 2021
@astrogeco
Merge pull request #1115 from skliper/fix1071-init_status
2f5dfb3 
Fix #1071, Initialize Status in CFE_ES_WaitForSystemState
@astrogeco astrogeco mentioned this issue Feb 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Caelum
2 participants
@zanzaben @skliper