Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1071, Initialize Status in CFE_ES_WaitForSystemState #1115

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Fix #1071, Initialize Status in CFE_ES_WaitForSystemState #1115

merged 1 commit into from
Feb 3, 2021

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jan 22, 2021

Describe the contribution
Fix #1071 - initializes status in CFE_ES_WaitForSystemState and added missing success test case (would have failed!)

Testing performed
Build and run unit tests, passed.

Expected behavior changes
No longer returning uninitialized Status

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the 7.0.0 milestone Jan 22, 2021
@skliper skliper force-pushed the fix1071-init_status branch from 8841e77 to 1def3b5 Compare January 27, 2021 15:09
@astrogeco
Copy link
Contributor

CCB:2021-01-27 APPROVED

Actual bug, unit test was not checking for success

@astrogeco astrogeco changed the base branch from main to integration-candidate January 27, 2021 22:27
@astrogeco astrogeco force-pushed the integration-candidate branch from 54dffe8 to f6c6737 Compare February 3, 2021 02:48
@astrogeco astrogeco merged commit 2f5dfb3 into nasa:integration-candidate Feb 3, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Feb 3, 2021
@astrogeco
Add cFE FastTracked PRs
a59394b 
nasa/cFE#1101
nasa/cFE#1142
nasa/cFE#1139
nasa/cFE#1147
nasa/cFE#1114
nasa/cFE#1146
nasa/cFE#1120
nasa/cFE#1115
nasa/cFE#1113
nasa/cFE#1121
nasa/cFE#1112
nasa/cFE#1118
nasa/cFE#1124
@astrogeco astrogeco mentioned this pull request Feb 15, 2021
Merged
@skliper skliper deleted the fix1071-init_status branch April 1, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CCB:FastTrack
Projects
None yet
Milestone
Caelum
Development

Successfully merging this pull request may close these issues.

Initialize status in CFE_ES_WaitForSystemState
2 participants
@skliper @astrogeco