Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Software bus refactoring needed to prepare for future needs #2378

Closed
jphickey opened this issue Jun 16, 2023 · 0 comments · Fixed by #2381
Closed

Software bus refactoring needed to prepare for future needs #2378

jphickey opened this issue Jun 16, 2023 · 0 comments · Fixed by #2381
Assignees
@jphickey
Labels
enhancement

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Requests have been received for software bus features such as:

  • Better Message integrity checking
  • Better control over message routing and delivery
  • Timestamped commands (not just TLM)

Describe the solution you'd like
The software bus can support all of this but the internal workings need some refactoring and clean up to make it possible to fully integrate such features without duplicating the code.

Describe alternatives you've considered
N/A

Additional context
Breaking up the software bus functions into smaller bits of functionality allow for:

  • Different transmit/receive variants to use the same basic logic
  • Easier unit testing and maintenance of smaller routines
  • Reduced cyclomatic complexity of smaller routines
  • More code re-use between the two

This needs to be implemented before #2362 can be done.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Jun 16, 2023
jphickey added a commit to jphickey/cFE that referenced this issue Jun 16, 2023
@jphickey
Fix nasa#2378, refactor SB to support additional use cases
4f56d7c 
Cleans up the internal SB implementation so it can better support future
enhancements such as message integrity, additional header fields and
timestamping.
@jphickey jphickey mentioned this issue Jun 16, 2023
Merged
2 tasks
jphickey added a commit to jphickey/cFE that referenced this issue Nov 17, 2023
@jphickey
Fix nasa#2378, refactor SB to support additional use cases
c4141f9 
Cleans up the internal SB implementation so it can better support future
enhancements such as message integrity, additional header fields and
timestamping.
jphickey added a commit to jphickey/cFE that referenced this issue Dec 7, 2023
@jphickey
Fix nasa#2378, refactor SB to support additional use cases
0d27889 
Cleans up the internal SB implementation so it can better support future
enhancements such as message integrity, additional header fields and
timestamping.
jphickey added a commit to jphickey/cFE that referenced this issue Apr 18, 2024
@jphickey
Fix nasa#2378, refactor SB to support additional use cases
f20e60a 
Cleans up the internal SB implementation so it can better support future
enhancements such as message integrity, additional header fields and
timestamping.
jphickey added a commit to jphickey/cFE that referenced this issue Apr 19, 2024
@jphickey
Fix nasa#2378, refactor SB to support additional use cases
329695d 
Cleans up the internal SB implementation so it can better support future
enhancements such as message integrity, additional header fields and
timestamping.
jphickey added a commit to jphickey/cFE that referenced this issue Apr 19, 2024
@jphickey
Fix nasa#2378, refactor SB to support additional use cases
ea02a67 
Cleans up the internal SB implementation so it can better support future
enhancements such as message integrity, additional header fields and
timestamping.
jphickey added a commit to jphickey/cFE that referenced this issue Apr 19, 2024
@jphickey
Fix nasa#2378, update for code coverage
48dd153 
Restructure some switch statements and add a "default" case so they
are not flagged as having a missing branch in the coverage test.
dzbaker added a commit that referenced this issue May 2, 2024
@dzbaker
Merge pull request #2381 from jphickey:fix-2378-sb-refactor
64b6837 
Fix #2378, refactor SB to support additional use cases
@dzbaker dzbaker mentioned this issue May 6, 2024
Merged
2 tasks
@dzbaker dzbaker closed this as completed in 550e7f7 Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2378, refactor SB to support additional use cases jphickey/cFE
2 participants
@jphickey @chillfig