Fix #2030, array length calculation for perf structs #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleans up the array length calculation for perf structs to not assume a specific base element type (uint32). This also makes the definitions much more readable.
jphickey
added
the
CCB:Ready
skliper
approved these changes
Jan 18, 2022
astrogeco
removed
the
CCB:Ready
|
CCB:2022-01-19 APPROVED
|
astrogeco
added
the
CCB:Approved
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jan 19, 2022
*cFE* nasa/cFE#2015, Add FS Functional test nasa/cFE#2012, Fix mismatched foreach in cmake function nasa/cFE#2013, Improved code highlighting in cFE Application Developers Guide nasa/cFE#2027, CFE_FS_ParseInputFileNameEx avoid uninit var nasa/cFE#2031, Fix array length calculation for perf structs nasa/cFE#2023, Limit SBR UT loops nasa/cFE#2029, Initialize BlockData in ES UT nasa/cFE#2025, Fix osal_id_t type conversion in es_UT.c
This was referenced Jan 19, 2022
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jan 20, 2022
*cFE* nasa/cFE#2011, Reuse CodeQL, Static Analysis, and Format Check nasa/cFE#2015, Add FS Functional test nasa/cFE#2012, Fix mismatched foreach in cmake function nasa/cFE#2013, Improved code highlighting in cFE Application Developers Guide nasa/cFE#2027, CFE_FS_ParseInputFileNameEx avoid uninit var nasa/cFE#2031, Fix array length calculation for perf structs nasa/cFE#2023, Limit SBR UT loops nasa/cFE#2029, Initialize BlockData in ES UT nasa/cFE#2025, Fix osal_id_t type conversion in es_UT.c
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jan 21, 2022
Combines: nasa/cFE#2019, cFE v7.0.0-rc4+dev60 nasa/osal#1212, osal v6.0.0-rc4+dev29 nasa/sch_lab#105, sch_lab v2.5.0-rc4+dev13 Includes: *cFE* nasa/cFE#2033, Add CFE_ES_AppInfo_t element documentation nasa/cFE#2011, Reuse CodeQL, Static Analysis, and Format Check nasa/cFE#2015, Add FS Functional test nasa/cFE#2012, Fix mismatched foreach in cmake function nasa/cFE#2013, Improved code highlighting in cFE Application Developers Guide nasa/cFE#2027, CFE_FS_ParseInputFileNameEx avoid uninit var nasa/cFE#2031, Fix array length calculation for perf structs nasa/cFE#2023, Limit SBR UT loops nasa/cFE#2029, Initialize BlockData in ES UT nasa/cFE#2025, Fix osal_id_t type conversion in es_UT.c *osal* nasa/osal#1206, Search global and local symbol tables nasa/osal#1201, Add missing space to UtAssert_STUB_COUNT nasa/osal#1202, Add UINT8 and UINT16 equivalents for UtAssert_UINT32_<Comparison> macros nasa/osal#1203, correct warnings on gcc11 nasa/osal#1211, Set output in OS_stat handler nasa/osal#1190, Reuse CodeQL, Static Analysis, Format Check *other* nasa/sch_lab#104, Add option to configure base tick rate *Continuous Integration Updates* nasa/PSP#317, Reuse CodeQL, Static Analysis, and Format Check nasa/sample_lib#72, Reuse CodeQL, Static Analysis, and Format Check nasa/sample_app#162, Reuse CodeQL, Static Analysis, and Format Check nasa/ci_lab#100, Reuse CodeQL, Static Analysis, and Format Check nasa/to_lab#111, Reuse CodeQL, Static Analysis, and Format Check nasa/tblCRCTool#59, Reuse CodeQL, Static Analysis, and Format Check nasa/elf2cfetbl#97, Reuse CodeQL, Static Analysis, and Format Check nasa/cFS-GroundSystem#200, Reuse CodeQL, Static Analysis, and Format Check Co-authored-by: Ariel Adams <ArielSAdamsNASA@users.noreply.github.com> Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored-by: Kurtis Dinelle <kurtjd@users.noreply.github.com> Co-authored-by: Paul <paulober@users.noreply.github.com> Co-authored-by: Adrien Chardon <Nodraak@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Cleans up the array length calculation for perf structs to not assume a specific base element type (uint32). This also makes the definitions much more readable.
Fixes #2030
Testing performed
Build and sanity check CFE
Expected behavior changes
None w/current structure definitions. Just a bit of future-proofing and clean up.
System(s) tested on
Ubuntu 21.10
Additional context
Notably the EDS build actually does use a different base type for this array, so this is not just cosmetic. But this is a worthwhile cleanup regardless.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.