Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1204, Search global and local symbol tables #1206

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jan 12, 2022

Describe the contribution

Testing performed
DRAFT - not complete yet

Expected behavior changes
Improved portability, recovers prior behavior and will find symbols even if loaded as local only.

System(s) tested on

  • Hardware: i5/Docker
  • OS: Ubuntu 18.04
  • Versions: Bundle main

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the Draco milestone Jan 12, 2022
@skliper
Copy link
Contributor Author

skliper commented Jan 12, 2022

Currently in draft for preliminary review, still need to update unit tests.

- Refactors symbol table searching to include
  both local and global symbol tables for POSIX
- Renamed global search to generic since there
  isn't currently a use case for global only search
@skliper skliper force-pushed the fix1204_symbollookup branch from 296c16d to 82487f9 Compare January 18, 2022 14:53
@skliper skliper marked this pull request as ready for review January 18, 2022 15:05
@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jan 18, 2022
@astrogeco astrogeco removed the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jan 19, 2022
@astrogeco astrogeco requested a review from jphickey January 19, 2022 14:53
@astrogeco astrogeco added the CCB:Approved Indicates code review and approval by community CCB label Jan 19, 2022
@astrogeco
Copy link
Contributor

CCB:2022-01-19 APPROVED

  • Had to be implemented at the implementation level
  • Adds test to find in both global and local symbols

astrogeco added a commit to nasa/cFS that referenced this pull request Jan 19, 2022
*osal*

nasa/osal#1206, Search global and local symbol tables

nasa/osal#1201, Add missing space to UtAssert_STUB_COUNT

nasa/osal#1202, Add UINT8 and UINT16 equivalents for UtAssert_UINT32_<Comparison> macros

nasa/osal#1203, correct warnings on gcc11

nasa/osal#1211, Set output in OS_stat handler

*Authors*

skliper
jphickey
kurtjd
astrogeco added a commit to nasa/cFS that referenced this pull request Jan 20, 2022
*osal*

nasa/osal#1206, Search global and local symbol tables

nasa/osal#1201, Add missing space to UtAssert_STUB_COUNT

nasa/osal#1202, Add UINT8 and UINT16 equivalents for UtAssert_UINT32_<Comparison> macros

nasa/osal#1203, correct warnings on gcc11

nasa/osal#1211, Set output in OS_stat handler

*Authors*

skliper
jphickey
kurtjd
astrogeco added a commit to nasa/cFS that referenced this pull request Jan 20, 2022
*osal*

nasa/osal#1206, Search global and local symbol tables

nasa/osal#1201, Add missing space to UtAssert_STUB_COUNT

nasa/osal#1202, Add UINT8 and UINT16 equivalents for UtAssert_UINT32_<Comparison> macros

nasa/osal#1203, correct warnings on gcc11

nasa/osal#1211, Set output in OS_stat handler

nasa/osal#1190, Reuse CodeQL, Static Analysis, Format Check

*Authors*

skliper
jphickey
kurtjd
@astrogeco astrogeco merged commit 92308d9 into nasa:main Jan 21, 2022
astrogeco added a commit to nasa/cFS that referenced this pull request Jan 21, 2022
Combines:

nasa/cFE#2019, cFE v7.0.0-rc4+dev60
nasa/osal#1212, osal v6.0.0-rc4+dev29
nasa/sch_lab#105, sch_lab v2.5.0-rc4+dev13

Includes:

*cFE*

nasa/cFE#2033, Add CFE_ES_AppInfo_t element documentation
nasa/cFE#2011, Reuse CodeQL, Static Analysis, and Format Check
nasa/cFE#2015, Add FS Functional test
nasa/cFE#2012, Fix mismatched foreach in cmake function
nasa/cFE#2013, Improved code highlighting in cFE Application Developers Guide
nasa/cFE#2027, CFE_FS_ParseInputFileNameEx avoid uninit var
nasa/cFE#2031, Fix array length calculation for perf structs
nasa/cFE#2023, Limit SBR UT loops
nasa/cFE#2029, Initialize BlockData in ES UT
nasa/cFE#2025, Fix osal_id_t type conversion in es_UT.c

*osal*

nasa/osal#1206, Search global and local symbol tables
nasa/osal#1201, Add missing space to UtAssert_STUB_COUNT
nasa/osal#1202, Add UINT8 and UINT16 equivalents for UtAssert_UINT32_<Comparison> macros
nasa/osal#1203, correct warnings on gcc11
nasa/osal#1211, Set output in OS_stat handler
nasa/osal#1190, Reuse CodeQL, Static Analysis, Format Check

*other*

nasa/sch_lab#104, Add option to configure base tick rate

*Continuous Integration Updates*

nasa/PSP#317, Reuse CodeQL, Static Analysis, and Format Check

nasa/sample_lib#72, Reuse CodeQL, Static Analysis, and Format Check
nasa/sample_app#162, Reuse CodeQL, Static Analysis, and Format Check
nasa/ci_lab#100, Reuse CodeQL, Static Analysis, and Format Check
nasa/to_lab#111, Reuse CodeQL, Static Analysis, and Format Check

nasa/tblCRCTool#59, Reuse CodeQL, Static Analysis, and Format Check
nasa/elf2cfetbl#97, Reuse CodeQL, Static Analysis, and Format Check
nasa/cFS-GroundSystem#200, Reuse CodeQL, Static Analysis, and Format Check

Co-authored-by: Ariel Adams     <ArielSAdamsNASA@users.noreply.github.com>
Co-authored-by: Jacob Hageman   <skliper@users.noreply.github.com>
Co-authored-by: Joseph Hickey   <jphickey@users.noreply.github.com>
Co-authored-by: Kurtis Dinelle  <kurtjd@users.noreply.github.com>
Co-authored-by: Paul            <paulober@users.noreply.github.com>
Co-authored-by: Adrien Chardon  <Nodraak@users.noreply.github.com>
@skliper skliper deleted the fix1204_symbollookup branch April 19, 2022 20:46
jphickey added a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Add PSP version info to ES Housekeeping TLM messages.
This is equivalent to OSAL version info.

Changes both to use the proper version API.
jphickey added a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB draco-rc1 enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OS_SymbolLookup should also support local symbol lookup
3 participants