Fix #1398, Consistent use of CFE_EVS_EventType_Enum_t for EventType
#2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
thnkslprpt
force-pushed
the
fix-1398-consistent-use-of-typedef-for-EventType
branch
from
c345824 to
1f73f8b
Compare
thnkslprpt
force-pushed
the
fix-1398-consistent-use-of-typedef-for-EventType
branch
from
1f73f8b to
4d60bc3
Compare
thnkslprpt
force-pushed
the
fix-1398-consistent-use-of-typedef-for-EventType
branch
from
4d60bc3 to
af51f08
Compare
There was a problem hiding this comment.
CodeQL-coding-standard found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
dzbaker
added
the
CCB:Ready
dzbaker
added
CCB:Approved
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Dec 10, 2024
*Combines:* cFE equuleus-rc1+dev219 osal equuleus-rc1+dev93 PSP equuleus-rc1+dev55 cFS-GroundSystem equuleus-rc1+dev14 **Includes:** *cFE* - nasa/cFE#2308 - nasa/cFE#2612 - nasa/cFE#2616 - nasa/cFE#2309 *osal* - nasa/osal#1486 *PSP* - nasa/PSP#441 *cFS-GroundSystem* - nasa/cFS-GroundSystem#233 - nasa/cFS-GroundSystem#235 - nasa/cFS-GroundSystem#236 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Tvisha Andharia <tandharia@users.noreply.github.com> Co-authored by: Chris Knight <CDKnightNASA@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Dec 10, 2024
*Combines:* cFE equuleus-rc1+dev219 osal equuleus-rc1+dev93 PSP equuleus-rc1+dev55 cFS-GroundSystem equuleus-rc1+dev14 **Includes:** *cFE* - nasa/cFE#2308 - nasa/cFE#2612 - nasa/cFE#2616 - nasa/cFE#2309 *osal* - nasa/osal#1486 *PSP* - nasa/PSP#441 *cFS-GroundSystem* - nasa/cFS-GroundSystem#233 - nasa/cFS-GroundSystem#235 - nasa/cFS-GroundSystem#236 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Tvisha Andharia <tandharia@users.noreply.github.com> Co-authored by: Chris Knight <CDKnightNASA@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Dec 10, 2024
*Combines:* cFE equuleus-rc1+dev219 osal equuleus-rc1+dev93 PSP equuleus-rc1+dev55 cFS-GroundSystem equuleus-rc1+dev14 **Includes:** *cFE* - nasa/cFE#2308 - nasa/cFE#2612 - nasa/cFE#2616 - nasa/cFE#2309 *osal* - nasa/osal#1486 *PSP* - nasa/PSP#441 *cFS-GroundSystem* - nasa/cFS-GroundSystem#233 - nasa/cFS-GroundSystem#235 - nasa/cFS-GroundSystem#236 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Tvisha Andharia <tandharia@users.noreply.github.com> Co-authored by: Chris Knight <CDKnightNASA@users.noreply.github.com>
thnkslprpt
deleted the
fix-1398-consistent-use-of-typedef-for-EventType
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
CFE_EVS_EventType_Enum_t(and clarify vs mask) #1398EventTypeparameters/variables declared explicitly asint16converted over to use the defined typeNote: #1447 and #1438 are unresolved but it seems unlikely the enum will be removed completely. I think it is worth clearing this issue up in the meantime - to improve consistency in cFE.
Testing performed
GitHub CI actions all passing successfully.
Expected behavior changes
No change.
Contributor Info
Avi Weiss @thnkslprpt