Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #234, Update incorrect variable descriptions in tlm.txt #235

Merged

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Mar 22, 2023

Describe the contribution

Testing performed
GitHub CI actions all passing successfully, and local test confirmed added variable appearing correctly in the GUI:

Screenshot 2023-03-22 20 24 54

Expected behavior changes
Correct variables appear in the GUI now for these HK telemetry struct variables.

System(s) tested on
Intel(R) Celeron(R) N4100 CPU @ 1.10GHz x86_64
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS.

Contributor Info
Avi Weiss @thnkslprpt

@github-advanced-security
Copy link

You have successfully added a new CppCheck configuration cppcheck. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-advanced-security
Copy link

You have successfully added a new CodeQL-security configuration security. As part of the setup process, we have scanned this repository and found 1 existing alert. Please check the repository Security tab to see all alerts.

@github-advanced-security
Copy link

You have successfully added a new CodeQL-coding-standard configuration coding-standard. As part of the setup process, we have scanned this repository and found 22 existing alerts. Please check the repository Security tab to see all alerts.

@dzbaker dzbaker added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Nov 27, 2024
@thnkslprpt thnkslprpt force-pushed the fix-234-update-incorrect-tlm-txt-variables branch from 60d8733 to 1614cc4 Compare November 28, 2024 07:57
@dzbaker dzbaker added CCB:Approved Indicates approval by CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Dec 5, 2024
dzbaker added a commit to nasa/cFS that referenced this pull request Dec 10, 2024
*Combines:*

cFE equuleus-rc1+dev219
osal equuleus-rc1+dev93
PSP equuleus-rc1+dev55
cFS-GroundSystem equuleus-rc1+dev14

**Includes:**

*cFE*
- nasa/cFE#2308
- nasa/cFE#2612
- nasa/cFE#2616
- nasa/cFE#2309

*osal*
- nasa/osal#1486

*PSP*
- nasa/PSP#441

*cFS-GroundSystem*
- nasa/cFS-GroundSystem#233
- nasa/cFS-GroundSystem#235
- nasa/cFS-GroundSystem#236

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Tvisha Andharia <tandharia@users.noreply.github.com>
Co-authored by: Chris Knight <CDKnightNASA@users.noreply.github.com>
@dzbaker dzbaker mentioned this pull request Dec 10, 2024
2 tasks
dzbaker added a commit to nasa/cFS that referenced this pull request Dec 10, 2024
*Combines:*

cFE equuleus-rc1+dev219
osal equuleus-rc1+dev93
PSP equuleus-rc1+dev55
cFS-GroundSystem equuleus-rc1+dev14

**Includes:**

*cFE*
- nasa/cFE#2308
- nasa/cFE#2612
- nasa/cFE#2616
- nasa/cFE#2309

*osal*
- nasa/osal#1486

*PSP*
- nasa/PSP#441

*cFS-GroundSystem*
- nasa/cFS-GroundSystem#233
- nasa/cFS-GroundSystem#235
- nasa/cFS-GroundSystem#236

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Tvisha Andharia <tandharia@users.noreply.github.com>
Co-authored by: Chris Knight <CDKnightNASA@users.noreply.github.com>
@dzbaker dzbaker merged commit e492624 into nasa:main Dec 10, 2024
10 checks passed
dzbaker added a commit to nasa/cFS that referenced this pull request Dec 10, 2024
*Combines:*

cFE equuleus-rc1+dev219
osal equuleus-rc1+dev93
PSP equuleus-rc1+dev55
cFS-GroundSystem equuleus-rc1+dev14

**Includes:**

*cFE*
- nasa/cFE#2308
- nasa/cFE#2612
- nasa/cFE#2616
- nasa/cFE#2309

*osal*
- nasa/osal#1486

*PSP*
- nasa/PSP#441

*cFS-GroundSystem*
- nasa/cFS-GroundSystem#233
- nasa/cFS-GroundSystem#235
- nasa/cFS-GroundSystem#236

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Tvisha Andharia <tandharia@users.noreply.github.com>
Co-authored by: Chris Knight <CDKnightNASA@users.noreply.github.com>
@thnkslprpt thnkslprpt deleted the fix-234-update-incorrect-tlm-txt-variables branch December 10, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates approval by CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing/Incorrect variables in cfe tlm.txt files
2 participants