Fix #909, reorganize ES public API + msg definitions #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put all ES typedefs which are shared across API and telemetry messages into the "cfe_es_extern_typedefs.h" file. Put all ES typedefs which define the telemetry interface into the "cfe_es_msg.h" file. Also include structures which define the output of commands that write data files into this group (query all apps, query all tasks, query all CDS). Removes some localized definitions and replace with MISSION scope definitions where appropriate/necessary.
ghost
approved these changes
Oct 27, 2020
As the name field is a multiple of 4 bytes, there needs to be 3 bytes of padding, not 1, to avoid implicit padding. This doesn't change anything, it just makes the padding explicit instead of implicit.
jphickey
added
the
CCB:Ready
Simple replacement of CFE_MISSION_ES_CDS_MAX_NAME_LEN with CFE_MISSION_ES_CDS_MAX_FULL_NAME_LEN, to differentiate it from CFE_MISSION_ES_CDS_MAX_NAME_LENGTH - which is the CDS name without the app name.
This was
linked to
issues
Oct 27, 2020
|
CCB 2020-10-28 APPROVED
|
astrogeco
removed
the
CCB:Ready
|
Discussed at splinter, moving bool didn't sound like it would be an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Put all ES typedefs which are shared across API and telemetry messages into the
cfe_es_extern_typedefs.hfile.Put all ES typedefs which define the telemetry interface into the
cfe_es_msg.hfile. Also include structures which define the output of commands that write data files into this group (query all apps, query all tasks, query all CDS).Removes some localized definitions and replace with MISSION scope definitions where appropriate/necessary.
Fixes #909
Testing performed
Build and sanity check CFE
Run all unit tests
Expected behavior changes
No impact to behavior
(Should not change any binary formats)
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.