Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overall Tests Pass Even With a TSF #537

Closed
yammajamma opened this issue Jul 9, 2020 · 1 comment · Fixed by #579 or #590
Closed

Overall Tests Pass Even With a TSF #537

yammajamma opened this issue Jul 9, 2020 · 1 comment · Fixed by #579 or #590
Assignees
@skliper
Labels
bug
Milestone
Caelum

Comments

@yammajamma
Copy link
Contributor

yammajamma commented Jul 9, 2020 •
edited
Loading

Describe the bug
The software is set up such that overall tests pass even if there is a test case that TSF. I have had individual TSFs, and yet the overall tests showed everything passed.

See code here:

osal/ut_assert/src/utbsp.c

Line 213 in 80fdd67

if (TestCounters->CaseCount[UTASSERT_CASETYPE_FAILURE] > 0)

System observed on:
cFS Dev Server
OS: Ubuntu 18.04
Versions: OSAL 5.0.11.0

Reporter Info
Y. M. K.
Emergent
@skliper
Copy link
Contributor

skliper commented Jul 9, 2020

Yeah, I've run into two cases in cFE with TSF... probably should count these as CI failures.

@skliper skliper added this to the 5.2.0 milestone Aug 25, 2020
skliper added a commit to skliper/osal that referenced this issue Aug 25, 2020
@skliper
Fix nasa#537, Fail tests on startup and teardown failures
8190723
@skliper skliper mentioned this issue Aug 25, 2020
Merged
skliper added a commit to skliper/osal that referenced this issue Aug 25, 2020
@skliper
Fix nasa#537, Fail tests on startup and teardown failures
1f4ccd0
skliper added a commit to skliper/osal that referenced this issue Aug 25, 2020
@skliper
Fix nasa#537, Fail tests on startup and teardown failures
c8c2bcd
@skliper skliper self-assigned this Sep 1, 2020
@skliper skliper modified the milestones: 5.2.0, 6.0.0 Sep 1, 2020
skliper added a commit to skliper/osal that referenced this issue Sep 2, 2020
@skliper
Fix nasa#537, Fail tests on startup and teardown failures
a5a0183
yammajamma added a commit that referenced this issue Sep 3, 2020
@yammajamma
Merge pull request #579 from skliper/fix537-ut-fail-on-tsf
756a874 
Fix #537, Fail tests on startup and tear down failures
@yammajamma yammajamma mentioned this issue Sep 3, 2020
Merged
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@skliper
Fix nasa#537, Remove private files from user's guide
9325ce2
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#538 from skliper/fix535-doxygen-pdf-gen
6ecd0f6 
Fix nasa#535 and nasa#537, User's guide doxygen issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
bug
Projects
None yet
Milestone
Caelum
3 participants
@skliper @astrogeco @yammajamma